diff mbox

[FFmpeg-devel,v2,4/4] avfilter/avfilter: update documentation of avfilter_graph_create_filter

Message ID 20191206070618.42407-4-quinkblack@foxmail.com
State New
Headers show

Commit Message

zhilizhao Dec. 6, 2019, 7:06 a.m. UTC
From: Zhao Zhili <zhilizhao@tencent.com>

---
 libavfilter/avfilter.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

zhilizhao Dec. 6, 2019, 7:13 a.m. UTC | #1
> On Dec 6, 2019, at 3:06 PM, quinkblack@foxmail.com wrote:
> 
> From: Zhao Zhili <zhilizhao@tencent.com>
> 
> ---
> libavfilter/avfilter.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavfilter/avfilter.h b/libavfilter/avfilter.h
> index 3eaa8a4089..197e12a625 100644
> --- a/libavfilter/avfilter.h
> +++ b/libavfilter/avfilter.h
> @@ -947,7 +947,7 @@ AVFilterContext *avfilter_graph_get_filter(AVFilterGraph *graph, const char *nam
> /**
>  * Create and add a filter instance into an existing graph.
>  * The filter instance is created from the filter filt and inited
> - * with the parameters args and opaque.
> + * with the parameters args. opaque is ignored currently.

It should be 'parameter args’. I will wait for more comments first.

>  *
>  * In case of success put in *filt_ctx the pointer to the created
>  * filter instance, otherwise set *filt_ctx to NULL.
> -- 
> 2.22.0
> 
> 
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Nicolas George Dec. 23, 2019, 4:18 p.m. UTC | #2
zhilizhao (12019-12-06):
> > + * with the parameters args. opaque is ignored currently.
> 
> It should be 'parameter args’. I will wait for more comments first.

I fixed it myself, swapped "currently ignored", added a precision in the
commit message of the first patch and pushed.

Thanks.

Regards,
diff mbox

Patch

diff --git a/libavfilter/avfilter.h b/libavfilter/avfilter.h
index 3eaa8a4089..197e12a625 100644
--- a/libavfilter/avfilter.h
+++ b/libavfilter/avfilter.h
@@ -947,7 +947,7 @@  AVFilterContext *avfilter_graph_get_filter(AVFilterGraph *graph, const char *nam
 /**
  * Create and add a filter instance into an existing graph.
  * The filter instance is created from the filter filt and inited
- * with the parameters args and opaque.
+ * with the parameters args. opaque is ignored currently.
  *
  * In case of success put in *filt_ctx the pointer to the created
  * filter instance, otherwise set *filt_ctx to NULL.