diff mbox

[FFmpeg-devel,4/4] avcodec/libx265: disable openGOP by default

Message ID 20191230192009.2462-4-jamrial@gmail.com
State New
Headers show

Commit Message

James Almer Dec. 30, 2019, 7:20 p.m. UTC 
This is in line with the behavior of libx264.

Signed-off-by: James Almer <jamrial@gmail.com>
---
 libavcodec/libx265.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Derek Buitenhuis Dec. 30, 2019, 11:04 p.m. UTC | #1 
On 30/12/2019 19:20, James Almer wrote:
> This is in line with the behavior of libx264.
> 
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>  libavcodec/libx265.c | 1 +
>  1 file changed, 1 insertion(+)

How does this square with 841c1efc78ace70497187d984adf31c7cc2cd7b6? During
review for that commit, the reason given for allowing it[0] was that libx264 had
the same default.

- Derek

[0] Thread (see replies, including your own): http://ffmpeg.org/pipermail/ffmpeg-devel/2018-June/230843.html
diff mbox

Patch

diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c
index a97bf19e91..7049a3144a 100644
--- a/libavcodec/libx265.c
+++ b/libavcodec/libx265.c
@@ -671,6 +671,7 @@  static const AVCodecDefault x265_defaults[] = {
     { "qcomp", "-1" },
     { "i_qfactor", "-1" },
     { "b_qfactor", "-1" },
+    { "flags", "+cgop" },
     { NULL },
 };