| Message ID | 20200106135539.22251-2-michael@niedermayer.cc |
|---|---|
| State | New |
| Headers | show |
| Series | [FFmpeg-devel,1/2] remove tests/ref/lavf/fits | expand |
| Context | Check | Description |
|---|---|---|
| andriy/ffmpeg-patchwork | success | Make fate finished |
On 1/6/2020 10:55 AM, Michael Niedermayer wrote: > The gif test should depend on gif not fits > > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> > --- > tests/fate/lavf-video.mak | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/fate/lavf-video.mak b/tests/fate/lavf-video.mak > index 7a70ac90ce..f6e98246c4 100644 > --- a/tests/fate/lavf-video.mak > +++ b/tests/fate/lavf-video.mak > @@ -6,7 +6,7 @@ FATE_LAVF_VIDEO-$(call ENCDEC, FITS, FITS) += gbrp.fits > FATE_LAVF_VIDEO-$(call ENCDEC, FITS, FITS) += gbrap.fits > FATE_LAVF_VIDEO-$(call ENCDEC, FITS, FITS) += gbrp16be.fits > FATE_LAVF_VIDEO-$(call ENCDEC, FITS, FITS) += gbrap16be.fits > -FATE_LAVF_VIDEO-$(call ENCDEC, GIF, FITS) += gif > +FATE_LAVF_VIDEO-$(call ENCDEC, GIF, GIF) += gif Before ac4b5d86222006fa71ffe5922e1a34f1422507d8 it was IMAGE2, not GIF for the decoder part, so probably better to use that again. > FATE_LAVF_VIDEO-$(CONFIG_YUV4MPEGPIPE_MUXER) += y4m > > FATE_LAVF_VIDEO = $(FATE_LAVF_VIDEO-yes:%=fate-lavf-%) > Make the commit message "fix fate-lavf-gif dependencies" instead of "better looking gif dependancies". And mention the above commit as the source of the regression. LGTM otherwise.
Am Mo., 6. Jan. 2020 um 15:50 Uhr schrieb James Almer <jamrial@gmail.com>: > > On 1/6/2020 10:55 AM, Michael Niedermayer wrote: > > The gif test should depend on gif not fits > > > > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> > > --- > > tests/fate/lavf-video.mak | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tests/fate/lavf-video.mak b/tests/fate/lavf-video.mak > > index 7a70ac90ce..f6e98246c4 100644 > > --- a/tests/fate/lavf-video.mak > > +++ b/tests/fate/lavf-video.mak > > @@ -6,7 +6,7 @@ FATE_LAVF_VIDEO-$(call ENCDEC, FITS, FITS) += gbrp.fits > > FATE_LAVF_VIDEO-$(call ENCDEC, FITS, FITS) += gbrap.fits > > FATE_LAVF_VIDEO-$(call ENCDEC, FITS, FITS) += gbrp16be.fits > > FATE_LAVF_VIDEO-$(call ENCDEC, FITS, FITS) += gbrap16be.fits > > -FATE_LAVF_VIDEO-$(call ENCDEC, GIF, FITS) += gif > > +FATE_LAVF_VIDEO-$(call ENCDEC, GIF, GIF) += gif > > Before ac4b5d86222006fa71ffe5922e1a34f1422507d8 it was IMAGE2, not GIF > for the decoder part, so probably better to use that again. The gif demuxer has to be used for this file. Carl Eugen
On Mon, Jan 06, 2020 at 11:43:29AM -0300, James Almer wrote: > On 1/6/2020 10:55 AM, Michael Niedermayer wrote: [...] > > FATE_LAVF_VIDEO-$(CONFIG_YUV4MPEGPIPE_MUXER) += y4m > > > > FATE_LAVF_VIDEO = $(FATE_LAVF_VIDEO-yes:%=fate-lavf-%) > > > > Make the commit message "fix fate-lavf-gif dependencies" instead of > "better looking gif dependancies". And mention the above commit as the > source of the regression. ok > > LGTM otherwise. will apply [...]
diff --git a/tests/fate/lavf-video.mak b/tests/fate/lavf-video.mak index 7a70ac90ce..f6e98246c4 100644 --- a/tests/fate/lavf-video.mak +++ b/tests/fate/lavf-video.mak @@ -6,7 +6,7 @@ FATE_LAVF_VIDEO-$(call ENCDEC, FITS, FITS) += gbrp.fits FATE_LAVF_VIDEO-$(call ENCDEC, FITS, FITS) += gbrap.fits FATE_LAVF_VIDEO-$(call ENCDEC, FITS, FITS) += gbrp16be.fits FATE_LAVF_VIDEO-$(call ENCDEC, FITS, FITS) += gbrap16be.fits -FATE_LAVF_VIDEO-$(call ENCDEC, GIF, FITS) += gif +FATE_LAVF_VIDEO-$(call ENCDEC, GIF, GIF) += gif FATE_LAVF_VIDEO-$(CONFIG_YUV4MPEGPIPE_MUXER) += y4m FATE_LAVF_VIDEO = $(FATE_LAVF_VIDEO-yes:%=fate-lavf-%)
The gif test should depend on gif not fits Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> --- tests/fate/lavf-video.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)