diff mbox series

[FFmpeg-devel,1/4] avformat/udp: add newline after warning

Message ID 20200116002016.4528-1-cus@passwd.hu
State Accepted
Headers
Series [FFmpeg-devel,1/4] avformat/udp: add newline after warning |

Checks

Context Check Description
andriy/ffmpeg-patchwork success Make fate finished

Commit Message

Marton Balint Jan. 16, 2020, 12:20 a.m. UTC 
Signed-off-by: Marton Balint <cus@passwd.hu>
---
 libavformat/udp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jun Zhao Jan. 16, 2020, 11:28 a.m. UTC | #1 
On Thu, Jan 16, 2020 at 8:20 AM Marton Balint <cus@passwd.hu> wrote:
>
> Signed-off-by: Marton Balint <cus@passwd.hu>
> ---
>  libavformat/udp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/udp.c b/libavformat/udp.c
> index f4ec148a2f..e42a069b24 100644
> --- a/libavformat/udp.c
> +++ b/libavformat/udp.c
> @@ -861,7 +861,7 @@ static int udp_open(URLContext *h, const char *uri, int flags)
>          } else {
>              av_log(h, AV_LOG_DEBUG, "end receive buffer size reported is %d\n", tmp);
>              if(tmp < s->buffer_size)
> -                av_log(h, AV_LOG_WARNING, "attempted to set receive buffer to size %d but it only ended up set as %d", s->buffer_size, tmp);
> +                av_log(h, AV_LOG_WARNING, "attempted to set receive buffer to size %d but it only ended up set as %d\n", s->buffer_size, tmp);
>          }
>
>          /* make the socket non-blocking */
> --
> 2.16.4
>
LGTM
Marton Balint Jan. 25, 2020, 10:28 p.m. UTC | #2 
On Thu, 16 Jan 2020, mypopy@gmail.com wrote:

> On Thu, Jan 16, 2020 at 8:20 AM Marton Balint <cus@passwd.hu> wrote:
>>
>> Signed-off-by: Marton Balint <cus@passwd.hu>
>> ---
>>  libavformat/udp.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/libavformat/udp.c b/libavformat/udp.c
>> index f4ec148a2f..e42a069b24 100644
>> --- a/libavformat/udp.c
>> +++ b/libavformat/udp.c
>> @@ -861,7 +861,7 @@ static int udp_open(URLContext *h, const char *uri, int flags)
>>          } else {
>>              av_log(h, AV_LOG_DEBUG, "end receive buffer size reported is %d\n", tmp);
>>              if(tmp < s->buffer_size)
>> -                av_log(h, AV_LOG_WARNING, "attempted to set receive buffer to size %d but it only ended up set as %d", s->buffer_size, tmp);
>> +                av_log(h, AV_LOG_WARNING, "attempted to set receive buffer to size %d but it only ended up set as %d\n", s->buffer_size, tmp);
>>          }
>>
>>          /* make the socket non-blocking */
>> --
>> 2.16.4
>>
> LGTM

Thanks applied patches 1-3. Will send a new patch for patch 4.

Regards,
Marton
diff mbox series

Patch

diff --git a/libavformat/udp.c b/libavformat/udp.c
index f4ec148a2f..e42a069b24 100644
--- a/libavformat/udp.c
+++ b/libavformat/udp.c
@@ -861,7 +861,7 @@  static int udp_open(URLContext *h, const char *uri, int flags)
         } else {
             av_log(h, AV_LOG_DEBUG, "end receive buffer size reported is %d\n", tmp);
             if(tmp < s->buffer_size)
-                av_log(h, AV_LOG_WARNING, "attempted to set receive buffer to size %d but it only ended up set as %d", s->buffer_size, tmp);
+                av_log(h, AV_LOG_WARNING, "attempted to set receive buffer to size %d but it only ended up set as %d\n", s->buffer_size, tmp);
         }
 
         /* make the socket non-blocking */