diff mbox series

[FFmpeg-devel,v1] avcodec/libx264: return immediately if encode_nals return 0

Message ID 20200119155245.3297-1-lance.lmwang@gmail.com
State New
Headers show
Series [FFmpeg-devel,v1] avcodec/libx264: return immediately if encode_nals return 0
Related show


Context Check Description
andriy/ffmpeg-patchwork pending
andriy/ffmpeg-patchwork success Applied patch
andriy/ffmpeg-patchwork success Configure finished
andriy/ffmpeg-patchwork success Make finished
andriy/ffmpeg-patchwork success Make fate finished

Commit Message

Limin Wang Jan. 19, 2020, 3:52 p.m. UTC
From: Limin Wang <lance.lmwang@gmail.com>

x264_encoder_encode can return 0 with nnal 0. As a result, encode_nals will
return 0. In this condition, it's better to return 0 immediately to avoid
the following unneeded pict_type and flags setting.

Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
 libavcodec/libx264.c | 3 +++
 1 file changed, 3 insertions(+)
diff mbox series


diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c
index 77bf887..3dc15a4 100644
--- a/libavcodec/libx264.c
+++ b/libavcodec/libx264.c
@@ -437,6 +437,9 @@  static int X264_frame(AVCodecContext *ctx, AVPacket *pkt, const AVFrame *frame,
             return ret;
     } while (!ret && !frame && x264_encoder_delayed_frames(x4->enc));
+    if (!ret)
+        return 0;
     pkt->pts = pic_out.i_pts;
     pkt->dts = pic_out.i_dts;