| Message ID | 20200228210631.19477-2-andreas.rheinhardt@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [FFmpeg-devel,1/2] fftools/ffmpeg_opt: Fix leak of options when parsing options fails | expand |
| Context | Check | Description |
|---|---|---|
| andriy/ffmpeg-patchwork | success | Make fate finished |
lgtm On 2/28/20, Andreas Rheinhardt <andreas.rheinhardt@gmail.com> wrote: > The second ; in a double ;; is actually a null statement. It triggers > the typical declaration-after-statement compiler-warnings if it occurs > in the middle of several declarations (like here). > > Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com> > --- > libavfilter/vf_cas.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavfilter/vf_cas.c b/libavfilter/vf_cas.c > index a07d51a84e..7c32ed5f9b 100644 > --- a/libavfilter/vf_cas.c > +++ b/libavfilter/vf_cas.c > @@ -58,7 +58,7 @@ static int cas_slice8(AVFilterContext *avctx, void *arg, > int jobnr, int nb_jobs) > const int linesize = out->linesize[p]; > const int in_linesize = in->linesize[p]; > const int w = s->planewidth[p]; > - const int w1 = w - 1;; > + const int w1 = w - 1; > const int h = s->planeheight[p]; > const int h1 = h - 1; > uint8_t *dst = out->data[p] + slice_start * linesize; > @@ -125,7 +125,7 @@ static int cas_slice16(AVFilterContext *avctx, void > *arg, int jobnr, int nb_jobs > const int linesize = out->linesize[p] / 2; > const int in_linesize = in->linesize[p] / 2; > const int w = s->planewidth[p]; > - const int w1 = w - 1;; > + const int w1 = w - 1; > const int h = s->planeheight[p]; > const int h1 = h - 1; > uint16_t *dst = (uint16_t *)out->data[p] + slice_start * linesize; > -- > 2.20.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
On Fri, Feb 28, 2020 at 11:30:43PM +0100, Paul B Mahol wrote:
> lgtm
will apply
thx
[...]
diff --git a/libavfilter/vf_cas.c b/libavfilter/vf_cas.c index a07d51a84e..7c32ed5f9b 100644 --- a/libavfilter/vf_cas.c +++ b/libavfilter/vf_cas.c @@ -58,7 +58,7 @@ static int cas_slice8(AVFilterContext *avctx, void *arg, int jobnr, int nb_jobs) const int linesize = out->linesize[p]; const int in_linesize = in->linesize[p]; const int w = s->planewidth[p]; - const int w1 = w - 1;; + const int w1 = w - 1; const int h = s->planeheight[p]; const int h1 = h - 1; uint8_t *dst = out->data[p] + slice_start * linesize; @@ -125,7 +125,7 @@ static int cas_slice16(AVFilterContext *avctx, void *arg, int jobnr, int nb_jobs const int linesize = out->linesize[p] / 2; const int in_linesize = in->linesize[p] / 2; const int w = s->planewidth[p]; - const int w1 = w - 1;; + const int w1 = w - 1; const int h = s->planeheight[p]; const int h1 = h - 1; uint16_t *dst = (uint16_t *)out->data[p] + slice_start * linesize;
The second ; in a double ;; is actually a null statement. It triggers the typical declaration-after-statement compiler-warnings if it occurs in the middle of several declarations (like here). Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com> --- libavfilter/vf_cas.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)