diff mbox series

[FFmpeg-devel] configure: Add llviddsp to mvha deps

Message ID 20200311021315.236093-1-tfoucu@gmail.com
State New
Headers show
Series [FFmpeg-devel] configure: Add llviddsp to mvha deps
Related show

Checks

Context Check Description
andriy/ffmpeg-patchwork pending
andriy/ffmpeg-patchwork success Applied patch
andriy/ffmpeg-patchwork success Configure finished
andriy/ffmpeg-patchwork success Make finished
andriy/ffmpeg-patchwork success Make fate finished

Commit Message

Thierry Foucu March 11, 2020, 2:13 a.m. UTC
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Paul B Mahol March 11, 2020, 2:39 p.m. UTC | #1
lgtm

On 3/11/20, Thierry Foucu <tfoucu@gmail.com> wrote:
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 8b17134944..2d2e4d8817 100755
> --- a/configure
> +++ b/configure
> @@ -2790,7 +2790,7 @@ msmpeg4v3_decoder_select="h263_decoder"
>  msmpeg4v3_encoder_select="h263_encoder"
>  mss2_decoder_select="mpegvideo qpeldsp vc1_decoder"
>  mts2_decoder_select="mss34dsp"
> -mvha_decoder_deps="zlib"
> +mvha_decoder_select="llviddsp zlib"
>  mwsc_decoder_deps="zlib"
>  mxpeg_decoder_select="mjpeg_decoder"
>  nellymoser_decoder_select="mdct sinewin"
> --
> 2.25.1.481.gfbce0eb801-goog
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Michael Niedermayer March 11, 2020, 10:20 p.m. UTC | #2
On Wed, Mar 11, 2020 at 03:39:23PM +0100, Paul B Mahol wrote:
> lgtm

will apply

thx

[...]
Michael Niedermayer March 11, 2020, 10:35 p.m. UTC | #3
On Wed, Mar 11, 2020 at 11:20:48PM +0100, Michael Niedermayer wrote:
> On Wed, Mar 11, 2020 at 03:39:23PM +0100, Paul B Mahol wrote:
> > lgtm
> 
> will apply

actually, i wont apply this yet, it looks a bit odd

-mvha_decoder_deps="zlib"
+mvha_decoder_select="llviddsp zlib"

zlib should be a _deps not _select i think

thx

[...]
Thierry Foucu March 12, 2020, 4:31 p.m. UTC | #4
On Wed, Mar 11, 2020 at 3:35 PM Michael Niedermayer <michaelni@gmx.at>
wrote:

> On Wed, Mar 11, 2020 at 11:20:48PM +0100, Michael Niedermayer wrote:
> > On Wed, Mar 11, 2020 at 03:39:23PM +0100, Paul B Mahol wrote:
> > > lgtm
> >
> > will apply
>
> actually, i wont apply this yet, it looks a bit odd
>
> -mvha_decoder_deps="zlib"
> +mvha_decoder_select="llviddsp zlib"
>
> zlib should be a _deps not _select i think
>
>
Correct. Let me send you another patch.


> thx
>
> [...]
>
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Rewriting code that is poorly written but fully understood is good.
> Rewriting code that one doesnt understand is a sign that one is less smart
> then the original author, trying to rewrite it will not make it better.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
diff mbox series

Patch

diff --git a/configure b/configure
index 8b17134944..2d2e4d8817 100755
--- a/configure
+++ b/configure
@@ -2790,7 +2790,7 @@  msmpeg4v3_decoder_select="h263_decoder"
 msmpeg4v3_encoder_select="h263_encoder"
 mss2_decoder_select="mpegvideo qpeldsp vc1_decoder"
 mts2_decoder_select="mss34dsp"
-mvha_decoder_deps="zlib"
+mvha_decoder_select="llviddsp zlib"
 mwsc_decoder_deps="zlib"
 mxpeg_decoder_select="mjpeg_decoder"
 nellymoser_decoder_select="mdct sinewin"