diff mbox series

[FFmpeg-devel,v3] web/generate-doc.sh: use --disable-x86asm instead of --disable-yasm

Message ID 20200314080801.88839-1-lq@chinaffmpeg.org
State New
Headers show
Series [FFmpeg-devel,v3] web/generate-doc.sh: use --disable-x86asm instead of --disable-yasm
Related show

Checks

Context Check Description
andriy/ffmpeg-patchwork pending
andriy/ffmpeg-patchwork warning Failed to apply patch

Commit Message

Steven Liu March 14, 2020, 8:08 a.m. UTC
Reviewed-by: Lou Logan <lou@lrcd.com>
Signed-off-by: Steven Liu <liuqi05@kuaishou.com>
---
 generate-doc.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Carl Eugen Hoyos March 14, 2020, 10:58 a.m. UTC | #1
Am Sa., 14. März 2020 um 09:08 Uhr schrieb Steven Liu <lq@chinaffmpeg.org>:
>
> Reviewed-by: Lou Logan <lou@lrcd.com>
> Signed-off-by: Steven Liu <liuqi05@kuaishou.com>
> ---
>  generate-doc.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/generate-doc.sh b/generate-doc.sh
> index d8d01d3..2da5e64 100755
> --- a/generate-doc.sh
> +++ b/generate-doc.sh
> @@ -34,7 +34,7 @@ export FA_ICONS=true
>
>  rm -rf build-doc
>  mkdir build-doc && cd build-doc
> -$src/configure --enable-gpl --disable-yasm || die "configure failed"

> +$src/configure --enable-gpl --disable-x86asm || die "configure failed"

Why isn't this "--disable-asm" which I expect to also work on (for
example) windows arm64 if gas-preprocessor is not installed?

Carl Eugen
Steven Liu March 14, 2020, 11:18 a.m. UTC | #2
> 2020年3月14日 下午6:58,Carl Eugen Hoyos <ceffmpeg@gmail.com> 写道:
> 
> Am Sa., 14. März 2020 um 09:08 Uhr schrieb Steven Liu <lq@chinaffmpeg.org>:
>> 
>> Reviewed-by: Lou Logan <lou@lrcd.com>
>> Signed-off-by: Steven Liu <liuqi05@kuaishou.com>
>> ---
>> generate-doc.sh | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/generate-doc.sh b/generate-doc.sh
>> index d8d01d3..2da5e64 100755
>> --- a/generate-doc.sh
>> +++ b/generate-doc.sh
>> @@ -34,7 +34,7 @@ export FA_ICONS=true
>> 
>> rm -rf build-doc
>> mkdir build-doc && cd build-doc
>> -$src/configure --enable-gpl --disable-yasm || die "configure failed"
> 
>> +$src/configure --enable-gpl --disable-x86asm || die "configure failed"
> 
> Why isn't this "--disable-asm" which I expect to also work on (for
> example) windows arm64 if gas-preprocessor is not installed?
Hi  Carl,


Because when I use the command line:

liuqi05:web liuqi$ ./generate-doc.sh ~/multimedia/ffmpeg/

it tell me :

License: GPL version 2 or later

WARNING: The --disable-yasm option is only provided for compatibility and will be
 removed in the future. Use --enable-x86asm / --disable-x86asm instead.
GEN	libavutil/libavutil.version

I think it need not use asm when just build documents.

Thanks

Steven
Steven Liu March 14, 2020, 11:22 a.m. UTC | #3
> 2020年3月14日 下午6:58,Carl Eugen Hoyos <ceffmpeg@gmail.com> 写道:
> 
> Am Sa., 14. März 2020 um 09:08 Uhr schrieb Steven Liu <lq@chinaffmpeg.org>:
>> 
>> Reviewed-by: Lou Logan <lou@lrcd.com>
>> Signed-off-by: Steven Liu <liuqi05@kuaishou.com>
>> ---
>> generate-doc.sh | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/generate-doc.sh b/generate-doc.sh
>> index d8d01d3..2da5e64 100755
>> --- a/generate-doc.sh
>> +++ b/generate-doc.sh
>> @@ -34,7 +34,7 @@ export FA_ICONS=true
>> 
>> rm -rf build-doc
>> mkdir build-doc && cd build-doc
>> -$src/configure --enable-gpl --disable-yasm || die "configure failed"
> 
>> +$src/configure --enable-gpl --disable-x86asm || die "configure failed"
> 
> Why isn't this "--disable-asm" which I expect to also work on (for
> example) windows arm64 if gas-preprocessor is not installed?
Ah, yes you are right, I should use disable-asm
> 
> Carl Eugen
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
diff mbox series

Patch

diff --git a/generate-doc.sh b/generate-doc.sh
index d8d01d3..2da5e64 100755
--- a/generate-doc.sh
+++ b/generate-doc.sh
@@ -34,7 +34,7 @@  export FA_ICONS=true
 
 rm -rf build-doc
 mkdir build-doc && cd build-doc
-$src/configure --enable-gpl --disable-yasm || die "configure failed"
+$src/configure --enable-gpl --disable-x86asm || die "configure failed"
 make doc || die "doc not made"
 cp doc/*.html ../htdocs/ || die "copy failed"