diff mbox series

[FFmpeg-devel] ffplay: flush correct stream after stats update

Message ID 20200403163246.914-1-ffmpeg@gyani.pro
State Accepted
Headers show
Series [FFmpeg-devel] ffplay: flush correct stream after stats update | expand

Checks

Context Check Description
andriy/ffmpeg-patchwork warning Failed to apply patch

Commit Message

Gyan Doshi April 3, 2020, 4:32 p.m. UTC 
Stats and logs are written to stderr, not stdout.
---
 fftools/ffplay.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Marton Balint April 4, 2020, 10 a.m. UTC | #1 
On Fri, 3 Apr 2020, Gyan Doshi wrote:

> Stats and logs are written to stderr, not stdout.
> ---
> fftools/ffplay.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fftools/ffplay.c b/fftools/ffplay.c
> index 416ebbf7df..1beec54293 100644
> --- a/fftools/ffplay.c
> +++ b/fftools/ffplay.c
> @@ -1736,7 +1736,7 @@ display:
>             else
>                 av_log(NULL, AV_LOG_INFO, "%s", buf.str);
> 
> -            fflush(stdout);
> +            fflush(stderr);

LGTM, thanks.

Marton
Gyan Doshi April 4, 2020, 10:33 a.m. UTC | #2 
On 04-04-2020 03:30 pm, Marton Balint wrote:
>
>
> On Fri, 3 Apr 2020, Gyan Doshi wrote:
>
>> Stats and logs are written to stderr, not stdout.
>> ---
>> fftools/ffplay.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fftools/ffplay.c b/fftools/ffplay.c
>> index 416ebbf7df..1beec54293 100644
>> --- a/fftools/ffplay.c
>> +++ b/fftools/ffplay.c
>> @@ -1736,7 +1736,7 @@ display:
>>             else
>>                 av_log(NULL, AV_LOG_INFO, "%s", buf.str);
>>
>> -            fflush(stdout);
>> +            fflush(stderr);
>
> LGTM, thanks.

Thanks. Pushed as b195b5f2ba3527172ff6ac28d018a6ba23262af9

Gyan
diff mbox series

Patch

diff --git a/fftools/ffplay.c b/fftools/ffplay.c
index 416ebbf7df..1beec54293 100644
--- a/fftools/ffplay.c
+++ b/fftools/ffplay.c
@@ -1736,7 +1736,7 @@  display:
             else
                 av_log(NULL, AV_LOG_INFO, "%s", buf.str);
 
-            fflush(stdout);
+            fflush(stderr);
             av_bprint_finalize(&buf, NULL);
 
             last_time = cur_time;