diff mbox series

[FFmpeg-devel] avformat/gopher: Support 'g' type

Message ID 20200421200145.20696-1-parazyd@dyne.org
State New
Headers show
Series [FFmpeg-devel] avformat/gopher: Support 'g' type
Related show

Checks

Context Check Description
andriy/default pending
andriy/make success Make finished
andriy/make_fate success Make fate finished

Commit Message

parazyd April 21, 2020, 8:01 p.m. UTC
This adds support for the gif gopher type. Since ffmpeg can work with GIF
files, it makes sense to support it in the Gopher protocol.

Signed-off-by: parazyd <parazyd@dyne.org>
---
 libavformat/gopher.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Marton Balint April 21, 2020, 8:13 p.m. UTC | #1
On Tue, 21 Apr 2020, parazyd wrote:

> This adds support for the gif gopher type. Since ffmpeg can work with GIF
> files, it makes sense to support it in the Gopher protocol.
>
> Signed-off-by: parazyd <parazyd@dyne.org>
> ---
> libavformat/gopher.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/libavformat/gopher.c b/libavformat/gopher.c
> index 3070b24caf..3420abd8fb 100644
> --- a/libavformat/gopher.c
> +++ b/libavformat/gopher.c
> @@ -46,6 +46,7 @@ static int gopher_connect(URLContext *h, const char *path)
>     switch (*++path) {
>         case '5':
>         case '9':
> +        case 'g':

'I' should also be added, no?

(I never imagined somebody is still using this :P)

Thanks,
Marton
Carl Eugen Hoyos April 21, 2020, 8:21 p.m. UTC | #2
Am Di., 21. Apr. 2020 um 22:13 Uhr schrieb Marton Balint <cus@passwd.hu>:
>
>
>
> On Tue, 21 Apr 2020, parazyd wrote:
>
> > This adds support for the gif gopher type. Since ffmpeg can work with GIF
> > files, it makes sense to support it in the Gopher protocol.
> >
> > Signed-off-by: parazyd <parazyd@dyne.org>
> > ---
> > libavformat/gopher.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/libavformat/gopher.c b/libavformat/gopher.c
> > index 3070b24caf..3420abd8fb 100644
> > --- a/libavformat/gopher.c
> > +++ b/libavformat/gopher.c
> > @@ -46,6 +46,7 @@ static int gopher_connect(URLContext *h, const char *path)
> >     switch (*++path) {
> >         case '5':
> >         case '9':
> > +        case 'g':
>
> 'I' should also be added, no?

I suggested the same but 'g' fails here with "Input/output error"

Carl Eugen
diff mbox series

Patch

diff --git a/libavformat/gopher.c b/libavformat/gopher.c
index 3070b24caf..3420abd8fb 100644
--- a/libavformat/gopher.c
+++ b/libavformat/gopher.c
@@ -46,6 +46,7 @@  static int gopher_connect(URLContext *h, const char *path)
     switch (*++path) {
         case '5':
         case '9':
+        case 'g':
             path = strchr(path, '/');
             if (!path) return AVERROR(EINVAL);
             break;