| Message ID | 20200430161736.21623-1-piotr@oleszczyk.eu |
|---|---|
| State | Accepted |
| Commit | b9746fcbee8f7d73662cefbf8695f1ab47483bac |
| Headers | show |
| Series | [FFmpeg-devel] ac3enc: fix AC3 downmix metadata issue | expand |
| Context | Check | Description |
|---|---|---|
| andriy/default | pending | |
| andriy/make | success | Make finished |
| andriy/make_fate | success | Make fate finished |
LGTM On 4/30/20, Piotr Oleszczyk <piotr@oleszczyk.eu> wrote: > Due to a typo, it was impossible to write 0.595 / -4.5 dB > of ltrt_cmixlev, ltrt_surmixlev, loro_cmixlev, loro_surmixlev. > Without any error 0.841 / -1.5 dB was written to file. > --- > libavcodec/ac3enc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/ac3enc.c b/libavcodec/ac3enc.c > index 7ce17db067..ddbc7b247c 100644 > --- a/libavcodec/ac3enc.c > +++ b/libavcodec/ac3enc.c > @@ -63,7 +63,7 @@ static const float > surmixlev_options[SURMIXLEV_NUM_OPTIONS] = { > > #define EXTMIXLEV_NUM_OPTIONS 8 > static const float extmixlev_options[EXTMIXLEV_NUM_OPTIONS] = { > - LEVEL_PLUS_3DB, LEVEL_PLUS_1POINT5DB, LEVEL_ONE, > LEVEL_MINUS_4POINT5DB, > + LEVEL_PLUS_3DB, LEVEL_PLUS_1POINT5DB, LEVEL_ONE, > LEVEL_MINUS_1POINT5DB, > LEVEL_MINUS_3DB, LEVEL_MINUS_4POINT5DB, LEVEL_MINUS_6DB, LEVEL_ZERO > }; > > -- > 2.17.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
On Thu, Apr 30, 2020 at 07:53:03PM +0200, Paul B Mahol wrote:
> LGTM
will apply
thx
[...]
diff --git a/libavcodec/ac3enc.c b/libavcodec/ac3enc.c index 7ce17db067..ddbc7b247c 100644 --- a/libavcodec/ac3enc.c +++ b/libavcodec/ac3enc.c @@ -63,7 +63,7 @@ static const float surmixlev_options[SURMIXLEV_NUM_OPTIONS] = { #define EXTMIXLEV_NUM_OPTIONS 8 static const float extmixlev_options[EXTMIXLEV_NUM_OPTIONS] = { - LEVEL_PLUS_3DB, LEVEL_PLUS_1POINT5DB, LEVEL_ONE, LEVEL_MINUS_4POINT5DB, + LEVEL_PLUS_3DB, LEVEL_PLUS_1POINT5DB, LEVEL_ONE, LEVEL_MINUS_1POINT5DB, LEVEL_MINUS_3DB, LEVEL_MINUS_4POINT5DB, LEVEL_MINUS_6DB, LEVEL_ZERO };