| Message ID | 20200528173148.6306-1-jratt0@gmail.com |
|---|---|
| State | Accepted |
| Commit | c367d14d0a5d4ce1c007f636ba85681915fd5f79 |
| Headers | show |
| Series | [FFmpeg-devel] Replace 'FontName' with 'Fontname' in the documentation. | expand |
| Context | Check | Description |
|---|---|---|
| andriy/default | pending | |
| andriy/make | success | Make finished |
| andriy/make_fate | success | Make fate finished |
Ping. First time contributing to this project, so I'm not sure if I missed something? On Thu, May 28, 2020 at 10:32 AM Joe Ratterman <jratt0@gmail.com> wrote: > This is the only use of 'FontName' with that capitalization, as both > source-code and tests use 'Fontname'. Having consistent capitalization > makes it easier to find the relevant source from the docs. > > See these examples for other uses: > libavcodec/ass_split.c:68 > tests/ref/fate/sub-cc:9 > --- > doc/filters.texi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/filters.texi b/doc/filters.texi > index 85a511b205..84afa1fff3 100644 > --- a/doc/filters.texi > +++ b/doc/filters.texi > @@ -17943,7 +17943,7 @@ subtitles=video.mkv:si=1 > To make the subtitles stream from @file{sub.srt} appear in 80% > transparent blue > @code{DejaVu Serif}, use: > @example > -subtitles=sub.srt:force_style='FontName=DejaVu > Serif,PrimaryColour=&HCCFF0000' > +subtitles=sub.srt:force_style='Fontname=DejaVu > Serif,PrimaryColour=&HCCFF0000' > @end example > > @section super2xsai > -- > 2.21.0 > >
On 02-07-2020 12:33 am, Joe Ratterman wrote: > Ping. > First time contributing to this project, so I'm not sure if I missed > something? Will apply. Thanks, Gyan > > On Thu, May 28, 2020 at 10:32 AM Joe Ratterman <jratt0@gmail.com> wrote: > >> This is the only use of 'FontName' with that capitalization, as both >> source-code and tests use 'Fontname'. Having consistent capitalization >> makes it easier to find the relevant source from the docs. >> >> See these examples for other uses: >> libavcodec/ass_split.c:68 >> tests/ref/fate/sub-cc:9 >> --- >> doc/filters.texi | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/doc/filters.texi b/doc/filters.texi >> index 85a511b205..84afa1fff3 100644 >> --- a/doc/filters.texi >> +++ b/doc/filters.texi >> @@ -17943,7 +17943,7 @@ subtitles=video.mkv:si=1 >> To make the subtitles stream from @file{sub.srt} appear in 80% >> transparent blue >> @code{DejaVu Serif}, use: >> @example >> -subtitles=sub.srt:force_style='FontName=DejaVu >> Serif,PrimaryColour=&HCCFF0000' >> +subtitles=sub.srt:force_style='Fontname=DejaVu >> Serif,PrimaryColour=&HCCFF0000' >> @end example >> >> @section super2xsai >> -- >> 2.21.0 >> >> > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
On 02-07-2020 12:49 am, Gyan Doshi wrote: > > > On 02-07-2020 12:33 am, Joe Ratterman wrote: >> Ping. >> First time contributing to this project, so I'm not sure if I missed >> something? > > Will apply. Pushed as c367d14d0a5d4ce1c007f636ba85681915fd5f79 Gyan
diff --git a/doc/filters.texi b/doc/filters.texi index 85a511b205..84afa1fff3 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -17943,7 +17943,7 @@ subtitles=video.mkv:si=1 To make the subtitles stream from @file{sub.srt} appear in 80% transparent blue @code{DejaVu Serif}, use: @example -subtitles=sub.srt:force_style='FontName=DejaVu Serif,PrimaryColour=&HCCFF0000' +subtitles=sub.srt:force_style='Fontname=DejaVu Serif,PrimaryColour=&HCCFF0000' @end example @section super2xsai
This is the only use of 'FontName' with that capitalization, as both source-code and tests use 'Fontname'. Having consistent capitalization makes it easier to find the relevant source from the docs. See these examples for other uses: libavcodec/ass_split.c:68 tests/ref/fate/sub-cc:9 --- doc/filters.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)