diff mbox series

[FFmpeg-devel,1/2] codec_desc: drop the INTRA_ONLY property from TAK

Message ID 20200609112019.21270-1-anton@khirnov.net
State Accepted
Commit 7321614a1b29ba4e92b47c5786a1739baaa25f9b
Headers show
Series [FFmpeg-devel,1/2] codec_desc: drop the INTRA_ONLY property from TAK
Related show

Checks

Context Check Description
andriy/default pending
andriy/make success Make finished
andriy/make_fate success Make fate finished

Commit Message

Anton Khirnov June 9, 2020, 11:20 a.m. UTC
It has key frames and non-key frames, so it is not intra-only.
---
 libavcodec/codec_desc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Paul B Mahol June 9, 2020, 11:34 a.m. UTC | #1
Not correct at all decoder is intra only it just have weird container,
this also makes it single threaded and much slower.

On 6/9/20, Anton Khirnov <anton@khirnov.net> wrote:
> It has key frames and non-key frames, so it is not intra-only.
> ---
>  libavcodec/codec_desc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c
> index 9f8847544f..f0f71e1074 100644
> --- a/libavcodec/codec_desc.c
> +++ b/libavcodec/codec_desc.c
> @@ -2897,7 +2897,7 @@ static const AVCodecDescriptor codec_descriptors[] = {
>          .type      = AVMEDIA_TYPE_AUDIO,
>          .name      = "tak",
>          .long_name = NULL_IF_CONFIG_SMALL("TAK (Tom's lossless Audio
> Kompressor)"),
> -        .props     = AV_CODEC_PROP_INTRA_ONLY | AV_CODEC_PROP_LOSSLESS,
> +        .props     = AV_CODEC_PROP_LOSSLESS,
>      },
>      {
>          .id        = AV_CODEC_ID_METASOUND,
> --
> 2.26.2
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Anton Khirnov June 9, 2020, 11:51 a.m. UTC | #2
Quoting Paul B Mahol (2020-06-09 13:34:21)
> Not correct at all decoder is intra only it just have weird container,

If it's intra only then why does the parser mark only some frames as
keyframes? And why does it need update_thread_context().

> this also makes it single threaded and much slower.

No it doesn't. It's just as multithreaded as before.
Paul B Mahol June 10, 2020, 11:11 a.m. UTC | #3
On 6/9/20, Anton Khirnov <anton@khirnov.net> wrote:
> Quoting Paul B Mahol (2020-06-09 13:34:21)
>> Not correct at all decoder is intra only it just have weird container,
>
> If it's intra only then why does the parser mark only some frames as
> keyframes? And why does it need update_thread_context().
>
>> this also makes it single threaded and much slower.
>
> No it doesn't. It's just as multithreaded as before.
>

If performance does not drop, patch is OK.

> --
> Anton Khirnov
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
diff mbox series

Patch

diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c
index 9f8847544f..f0f71e1074 100644
--- a/libavcodec/codec_desc.c
+++ b/libavcodec/codec_desc.c
@@ -2897,7 +2897,7 @@  static const AVCodecDescriptor codec_descriptors[] = {
         .type      = AVMEDIA_TYPE_AUDIO,
         .name      = "tak",
         .long_name = NULL_IF_CONFIG_SMALL("TAK (Tom's lossless Audio Kompressor)"),
-        .props     = AV_CODEC_PROP_INTRA_ONLY | AV_CODEC_PROP_LOSSLESS,
+        .props     = AV_CODEC_PROP_LOSSLESS,
     },
     {
         .id        = AV_CODEC_ID_METASOUND,