diff mbox series

[FFmpeg-devel,v3,1/5] avformat/argo_asf: add games to version list

Message ID 20200809234441.2365933-1-zane@zanevaniperen.com
State Accepted
Commit 97aaa15089c2a0e92b4336aeca7b7ae1b5516b57
Headers show
Series [FFmpeg-devel,v3,1/5] avformat/argo_asf: add games to version list
Related show

Checks

Context Check Description
andriy/default pending
andriy/make success Make finished
andriy/make_fate success Make fate finished

Commit Message

Zane van Iperen Aug. 9, 2020, 11:44 p.m. UTC
Signed-off-by: Zane van Iperen <zane@zanevaniperen.com>
---
 libavformat/argo_asf.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Alexander Strasser Aug. 10, 2020, 9:33 p.m. UTC | #1
Hi Zane,

thanks for addressing my comments in v3.

AFAICS you also took Andreas' feedback into account, but I didn't
check that.

No more remarks from me.


  Alexander
Zane van Iperen Aug. 10, 2020, 11:04 p.m. UTC | #2
On Mon, 10 Aug 2020 23:33:14 +0200
"Alexander Strasser" <eclipse7@gmx.net> wrote:

> 
> Hi Zane,
> 
> thanks for addressing my comments in v3.
> 
> AFAICS you also took Andreas' feedback into account, but I didn't
> check that.
> 

No worries. I'm pretty sure I handled everything...

> No more remarks from me.
> 
Cool, I'll shall push this tonight.

Zane
diff mbox series

Patch

diff --git a/libavformat/argo_asf.c b/libavformat/argo_asf.c
index 671b7482f9..94d3ae3e09 100644
--- a/libavformat/argo_asf.c
+++ b/libavformat/argo_asf.c
@@ -87,9 +87,12 @@  static void argo_asf_parse_chunk_header(ArgoASFChunkHeader *hdr, const uint8_t *
 
 /*
  * Known versions:
- * 1.1: The sample files in /game-formats/brender/part2.zip
+ * 1.1: https://samples.ffmpeg.org/game-formats/brender/part2.zip
+ *      FX Fighter
  * 1.2: Croc! Legend of the Gobbos
  * 2.1: Croc 2
+ *      The Emperor's New Groove
+ *      Disney's Aladdin in Nasira's Revenge
  */
 static int argo_asf_is_known_version(const ArgoASFFileHeader *hdr)
 {