diff mbox series

[FFmpeg-devel,4/5] avcodec/dvbsubdec: request samples for missing coding methods

Message ID 20200818205535.2974765-4-u@pkh.me
State Accepted
Commit b0f96f663c72801227f644ef86911c499859da0e
Headers show
Series [FFmpeg-devel,1/5] avcodec/dvbsubenc: merge rectangle encode code blocks | expand

Checks

Context Check Description
andriy/default pending
andriy/make success Make finished
andriy/make_fate success Make fate finished

Commit Message

Clément Bœsch Aug. 18, 2020, 8:55 p.m. UTC 
---
 libavcodec/dvbsubdec.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Comments

Michael Niedermayer Aug. 19, 2020, 10:39 a.m. UTC | #1 
On Tue, Aug 18, 2020 at 10:55:34PM +0200, Clément Bœsch wrote:
> ---
>  libavcodec/dvbsubdec.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)

LGTM

thx

[...]
diff mbox series

Patch

diff --git a/libavcodec/dvbsubdec.c b/libavcodec/dvbsubdec.c
index c179f6461c..1b75a2a46b 100644
--- a/libavcodec/dvbsubdec.c
+++ b/libavcodec/dvbsubdec.c
@@ -1032,9 +1032,10 @@  static int dvbsub_parse_object_segment(AVCodecContext *avctx,
             dvbsub_parse_pixel_data_block(avctx, display, block, bfl, 1,
                                             non_modifying_color);
         }
-
-/*  } else if (coding_method == 1) {*/
-
+    } else if (coding_method == 1) {
+        avpriv_report_missing_feature(avctx, "coded as a string of characters");
+    } else if (coding_method == 2) {
+        avpriv_report_missing_feature(avctx, "progressive coding of pixels");
     } else {
         av_log(avctx, AV_LOG_ERROR, "Unknown object coding %d\n", coding_method);
     }