diff mbox series

[FFmpeg-devel,V2,1/3] avcodec/cbs_av1: add support for frame restoration type

Message ID 20200902073130.18277-1-fei.w.wang@intel.com
State New
Headers show
Series [FFmpeg-devel,V2,1/3] avcodec/cbs_av1: add support for frame restoration type
Related show

Checks

Context Check Description
andriy/default pending
andriy/make success Make finished
andriy/make_fate success Make fate finished

Commit Message

Wang, Fei W Sept. 2, 2020, 7:31 a.m. UTC
Signed-off-by: Fei Wang <fei.w.wang@intel.com>
---
 libavcodec/av1.h | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Hendrik Leppkes Sept. 2, 2020, 8:48 a.m. UTC | #1
On Wed, Sep 2, 2020 at 9:34 AM Fei Wang <fei.w.wang@intel.com> wrote:
>
> Signed-off-by: Fei Wang <fei.w.wang@intel.com>
> ---
>  libavcodec/av1.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/libavcodec/av1.h b/libavcodec/av1.h
> index 6c0e32485b..0f99ae4829 100644
> --- a/libavcodec/av1.h
> +++ b/libavcodec/av1.h
> @@ -160,4 +160,12 @@ enum {
>      AV1_SCALABILITY_L4T7_KEY_SHIFT = 28,
>  };
>
> +// Frame Restoration types (section 6.10.15)
> +enum {
> +    AV1_RESTORE_NONE       = 0,
> +    AV1_RESTORE_WIENER     = 1,
> +    AV1_RESTORE_SGRPROJ    = 2,
> +    AV1_RESTORE_SWITCHABLE = 3,
> +};
> +
>  #endif /* AVCODEC_AV1_H */
> --


Is this patch missing some part to it, like, actually using those
values during parsing? :)

- Hendrik
James Almer Sept. 2, 2020, 3:42 p.m. UTC | #2
On 9/2/2020 5:48 AM, Hendrik Leppkes wrote:
> On Wed, Sep 2, 2020 at 9:34 AM Fei Wang <fei.w.wang@intel.com> wrote:
>>
>> Signed-off-by: Fei Wang <fei.w.wang@intel.com>
>> ---
>>  libavcodec/av1.h | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/libavcodec/av1.h b/libavcodec/av1.h
>> index 6c0e32485b..0f99ae4829 100644
>> --- a/libavcodec/av1.h
>> +++ b/libavcodec/av1.h
>> @@ -160,4 +160,12 @@ enum {
>>      AV1_SCALABILITY_L4T7_KEY_SHIFT = 28,
>>  };
>>
>> +// Frame Restoration types (section 6.10.15)
>> +enum {
>> +    AV1_RESTORE_NONE       = 0,
>> +    AV1_RESTORE_WIENER     = 1,
>> +    AV1_RESTORE_SGRPROJ    = 2,
>> +    AV1_RESTORE_SWITCHABLE = 3,
>> +};
>> +
>>  #endif /* AVCODEC_AV1_H */
>> --
> 
> 
> Is this patch missing some part to it, like, actually using those
> values during parsing? :)

Changed the only line in cbs_av1_syntax_template.c that i could find
making use of one of these, and pushed it.
diff mbox series

Patch

diff --git a/libavcodec/av1.h b/libavcodec/av1.h
index 6c0e32485b..0f99ae4829 100644
--- a/libavcodec/av1.h
+++ b/libavcodec/av1.h
@@ -160,4 +160,12 @@  enum {
     AV1_SCALABILITY_L4T7_KEY_SHIFT = 28,
 };
 
+// Frame Restoration types (section 6.10.15)
+enum {
+    AV1_RESTORE_NONE       = 0,
+    AV1_RESTORE_WIENER     = 1,
+    AV1_RESTORE_SGRPROJ    = 2,
+    AV1_RESTORE_SWITCHABLE = 3,
+};
+
 #endif /* AVCODEC_AV1_H */