diff mbox series

[FFmpeg-devel,17/40] avcodec/alacenc: Remove redundant code to free extradata

Message ID 20200914052747.124118-1-andreas.rheinhardt@gmail.com
State Accepted
Commit acda9ff6ce2b94a199a6967118fa19d58a09c146
Headers show
Series [FFmpeg-devel,01/16] avcodec/snowdec: Use ff_snow_common_init() directly
Related show

Checks

Context Check Description
andriy/default pending
andriy/make success Make finished
andriy/make_fate success Make fate finished

Commit Message

Andreas Rheinhardt Sept. 14, 2020, 5:27 a.m. UTC
It is already freed generically for encoders.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
---
 libavcodec/alacenc.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Paul B Mahol Sept. 14, 2020, 4:30 p.m. UTC | #1
On Mon, Sep 14, 2020 at 07:27:24AM +0200, Andreas Rheinhardt wrote:
> It is already freed generically for encoders.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
> ---
>  libavcodec/alacenc.c | 2 --
>  1 file changed, 2 deletions(-)

lgtm

> 
> diff --git a/libavcodec/alacenc.c b/libavcodec/alacenc.c
> index 804cc7b17b..fc5fa270e6 100644
> --- a/libavcodec/alacenc.c
> +++ b/libavcodec/alacenc.c
> @@ -498,8 +498,6 @@ static av_cold int alac_encode_close(AVCodecContext *avctx)
>  {
>      AlacEncodeContext *s = avctx->priv_data;
>      ff_lpc_end(&s->lpc_ctx);
> -    av_freep(&avctx->extradata);
> -    avctx->extradata_size = 0;
>      return 0;
>  }
>  
> -- 
> 2.25.1
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
diff mbox series

Patch

diff --git a/libavcodec/alacenc.c b/libavcodec/alacenc.c
index 804cc7b17b..fc5fa270e6 100644
--- a/libavcodec/alacenc.c
+++ b/libavcodec/alacenc.c
@@ -498,8 +498,6 @@  static av_cold int alac_encode_close(AVCodecContext *avctx)
 {
     AlacEncodeContext *s = avctx->priv_data;
     ff_lpc_end(&s->lpc_ctx);
-    av_freep(&avctx->extradata);
-    avctx->extradata_size = 0;
     return 0;
 }