diff mbox series

[FFmpeg-devel] doc/muxers: correct decribe of hls_enc_key and hls_enc_iv

Message ID 20201209012241.82320-1-liuqi05@kuaishou.com
State Superseded
Headers show
Series [FFmpeg-devel] doc/muxers: correct decribe of hls_enc_key and hls_enc_iv | expand

Checks

Context Check Description
andriy/x86_make success Make finished
andriy/x86_make_fate success Make fate finished
andriy/PPC64_make success Make finished

Commit Message

Steven Liu Dec. 9, 2020, 1:22 a.m. UTC
From: Steven Liu <liuqi05@kuaishou.com>

because hls_enc_key and hls_enc_iv get 16byte char
for example:
-hls_enc_key 0123456789abcdef -hls_enc_iv abcdefghijklmnop

Signed-off-by: liuqi05 <liuqi05@kuaishou.com>
---
 doc/muxers.texi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Gyan Doshi Dec. 9, 2020, 4:22 a.m. UTC | #1
On 09-12-2020 06:52 am, liuqi05 wrote:
> From: Steven Liu <liuqi05@kuaishou.com>
>
> because hls_enc_key and hls_enc_iv get 16byte char
> for example:
> -hls_enc_key 0123456789abcdef -hls_enc_iv abcdefghijklmnop
>
> Signed-off-by: liuqi05 <liuqi05@kuaishou.com>
> ---
>   doc/muxers.texi | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/doc/muxers.texi b/doc/muxers.texi
> index 179b923951..5907fd0ba0 100644
> --- a/doc/muxers.texi
> +++ b/doc/muxers.texi
> @@ -831,7 +831,7 @@ When enabled every segment generated is encrypted and the encryption key
>   is saved as @var{playlist name}.key.
>   
>   @item -hls_enc_key @var{key}
> -Hex-coded 16byte key to encrypt the segments, by default it
> +16byte key to encrypt the segments, by default it

16-byte or 16-octet (what RFC 8216 uses)

>   is randomly generated.
>   
>   @item -hls_enc_key_url @var{keyurl}
> @@ -839,7 +839,7 @@ If set, @var{keyurl} is prepended instead of @var{baseurl} to the key filename
>   in the playlist.
>   
>   @item -hls_enc_iv @var{iv}
> -Hex-coded 16byte initialization vector for every segment instead
> +16byte initialization vector for every segment instead

same
>   of the autogenerated ones.
>   
>   @item hls_segment_type @var{flags}

Regards,
Gyan
Gyan Doshi Dec. 9, 2020, 4:42 a.m. UTC | #2
And title:

doc/muxers: correct description of hls_enc_key and hls_enc_iv

On 09-12-2020 09:52 am, Gyan Doshi wrote:
>
>
> On 09-12-2020 06:52 am, liuqi05 wrote:
>> From: Steven Liu <liuqi05@kuaishou.com>
>>
>> because hls_enc_key and hls_enc_iv get 16byte char
>> for example:
>> -hls_enc_key 0123456789abcdef -hls_enc_iv abcdefghijklmnop
>>
>> Signed-off-by: liuqi05 <liuqi05@kuaishou.com>
>> ---
>>   doc/muxers.texi | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/doc/muxers.texi b/doc/muxers.texi
>> index 179b923951..5907fd0ba0 100644
>> --- a/doc/muxers.texi
>> +++ b/doc/muxers.texi
>> @@ -831,7 +831,7 @@ When enabled every segment generated is encrypted 
>> and the encryption key
>>   is saved as @var{playlist name}.key.
>>     @item -hls_enc_key @var{key}
>> -Hex-coded 16byte key to encrypt the segments, by default it
>> +16byte key to encrypt the segments, by default it
>
> 16-byte or 16-octet (what RFC 8216 uses)
>
>>   is randomly generated.
>>     @item -hls_enc_key_url @var{keyurl}
>> @@ -839,7 +839,7 @@ If set, @var{keyurl} is prepended instead of 
>> @var{baseurl} to the key filename
>>   in the playlist.
>>     @item -hls_enc_iv @var{iv}
>> -Hex-coded 16byte initialization vector for every segment instead
>> +16byte initialization vector for every segment instead
>
> same
>>   of the autogenerated ones.
>>     @item hls_segment_type @var{flags}
>
> Regards,
> Gyan
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Steven Liu Dec. 9, 2020, 5:35 a.m. UTC | #3
> 2020年12月9日 下午12:22,Gyan Doshi <ffmpeg@gyani.pro> 写道:
> 
> 
> 
> On 09-12-2020 06:52 am, liuqi05 wrote:
>> From: Steven Liu <liuqi05@kuaishou.com>
>> 
>> because hls_enc_key and hls_enc_iv get 16byte char
>> for example:
>> -hls_enc_key 0123456789abcdef -hls_enc_iv abcdefghijklmnop
>> 
>> Signed-off-by: liuqi05 <liuqi05@kuaishou.com>
>> ---
>>  doc/muxers.texi | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/doc/muxers.texi b/doc/muxers.texi
>> index 179b923951..5907fd0ba0 100644
>> --- a/doc/muxers.texi
>> +++ b/doc/muxers.texi
>> @@ -831,7 +831,7 @@ When enabled every segment generated is encrypted and the encryption key
>>  is saved as @var{playlist name}.key.
>>    @item -hls_enc_key @var{key}
>> -Hex-coded 16byte key to encrypt the segments, by default it
>> +16byte key to encrypt the segments, by default it
> 
> 16-byte or 16-octet (what RFC 8216 uses)
8216 said " [AES_128] encryption uses 16-octet keys.  If the KEYFORMAT of an EXT-
   X-KEY tag is "identity", the Key file is a single packed array of 16
   octets in binary format."
> 
>>  is randomly generated.
>>    @item -hls_enc_key_url @var{keyurl}
>> @@ -839,7 +839,7 @@ If set, @var{keyurl} is prepended instead of @var{baseurl} to the key filename
>>  in the playlist.
>>    @item -hls_enc_iv @var{iv}
>> -Hex-coded 16byte initialization vector for every segment instead
>> +16byte initialization vector for every segment instead
> 
> same
>>  of the autogenerated ones.
>>    @item hls_segment_type @var{flags}
> 
> Regards,
> Gyan
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Thanks

Steven Liu
Steven Liu Dec. 9, 2020, 5:40 a.m. UTC | #4
> 2020年12月9日 下午12:42,Gyan Doshi <ffmpeg@gyani.pro> 写道:
> 
> And title:
> 
> doc/muxers: correct description of hls_enc_key and hls_enc_iv
> 
> On 09-12-2020 09:52 am, Gyan Doshi wrote:
>> 
>> 
>> On 09-12-2020 06:52 am, liuqi05 wrote:
>>> From: Steven Liu <liuqi05@kuaishou.com>
>>> 
>>> because hls_enc_key and hls_enc_iv get 16byte char
>>> for example:
>>> -hls_enc_key 0123456789abcdef -hls_enc_iv abcdefghijklmnop
>>> 
>>> Signed-off-by: liuqi05 <liuqi05@kuaishou.com>
>>> ---
>>>   doc/muxers.texi | 4 ++--
>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>> 
>>> diff --git a/doc/muxers.texi b/doc/muxers.texi
>>> index 179b923951..5907fd0ba0 100644
>>> --- a/doc/muxers.texi
>>> +++ b/doc/muxers.texi
>>> @@ -831,7 +831,7 @@ When enabled every segment generated is encrypted and the encryption key
>>>   is saved as @var{playlist name}.key.
>>>     @item -hls_enc_key @var{key}
>>> -Hex-coded 16byte key to encrypt the segments, by default it
>>> +16byte key to encrypt the segments, by default it
>> 
>> 16-byte or 16-octet (what RFC 8216 uses)
>> 
>>>   is randomly generated.
>>>     @item -hls_enc_key_url @var{keyurl}
>>> @@ -839,7 +839,7 @@ If set, @var{keyurl} is prepended instead of @var{baseurl} to the key filename
>>>   in the playlist.
>>>     @item -hls_enc_iv @var{iv}
>>> -Hex-coded 16byte initialization vector for every segment instead
>>> +16byte initialization vector for every segment instead
>> 
>> same
>>>   of the autogenerated ones.
>>>     @item hls_segment_type @var{flags}
>> 
>> Regards,
>> Gyan

Thanks for your review, Gyan,
New version submitted.
https://patchwork.ffmpeg.org/project/ffmpeg/patch/20201209053922.91123-1-liuqi05@kuaishou.com/



Thanks

Steven Liu
diff mbox series

Patch

diff --git a/doc/muxers.texi b/doc/muxers.texi
index 179b923951..5907fd0ba0 100644
--- a/doc/muxers.texi
+++ b/doc/muxers.texi
@@ -831,7 +831,7 @@  When enabled every segment generated is encrypted and the encryption key
 is saved as @var{playlist name}.key.
 
 @item -hls_enc_key @var{key}
-Hex-coded 16byte key to encrypt the segments, by default it
+16byte key to encrypt the segments, by default it
 is randomly generated.
 
 @item -hls_enc_key_url @var{keyurl}
@@ -839,7 +839,7 @@  If set, @var{keyurl} is prepended instead of @var{baseurl} to the key filename
 in the playlist.
 
 @item -hls_enc_iv @var{iv}
-Hex-coded 16byte initialization vector for every segment instead
+16byte initialization vector for every segment instead
 of the autogenerated ones.
 
 @item hls_segment_type @var{flags}