| Message ID | 20201218173225.2652-1-jamrial@gmail.com |
|---|---|
| State | Accepted |
| Commit | 20b09b20a942d4aad38f9fa1324b713168d3db9a |
| Headers | show |
| Series | [FFmpeg-devel] avcodec/dpx: fix use of uninitialised value | expand |
| Context | Check | Description |
|---|---|---|
| andriy/x86_make | success | Make finished |
| andriy/x86_make_fate | fail | Make fate failed |
| andriy/PPC64_make | success | Make finished |
| andriy/PPC64_make_fate | warning | Make fate failed |
LGTM On Fri, Dec 18, 2020 at 6:41 PM James Almer <jamrial@gmail.com> wrote: > Found by Valgrind. > > Signed-off-by: James Almer <jamrial@gmail.com> > --- > libavcodec/dpx.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/dpx.c b/libavcodec/dpx.c > index bd431ccbcb..12bc165415 100644 > --- a/libavcodec/dpx.c > +++ b/libavcodec/dpx.c > @@ -333,10 +333,12 @@ static int decode_frame(AVCodecContext *avctx, > break; > case 50: // RGB > elements = 3; > + yuv = 0; > break; > case 52: // ABGR > case 51: // RGBA > elements = 4; > + yuv = 0; > break; > case 100: // UYVY422 > elements = 2; > -- > 2.29.2 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
On 12/18/2020 3:03 PM, Paul B Mahol wrote: > LGTM Applied. > > On Fri, Dec 18, 2020 at 6:41 PM James Almer <jamrial@gmail.com> wrote: > >> Found by Valgrind. >> >> Signed-off-by: James Almer <jamrial@gmail.com> >> --- >> libavcodec/dpx.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/libavcodec/dpx.c b/libavcodec/dpx.c >> index bd431ccbcb..12bc165415 100644 >> --- a/libavcodec/dpx.c >> +++ b/libavcodec/dpx.c >> @@ -333,10 +333,12 @@ static int decode_frame(AVCodecContext *avctx, >> break; >> case 50: // RGB >> elements = 3; >> + yuv = 0; >> break; >> case 52: // ABGR >> case 51: // RGBA >> elements = 4; >> + yuv = 0; >> break; >> case 100: // UYVY422 >> elements = 2; >> -- >> 2.29.2 >> >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> >> To unsubscribe, visit link above, or email >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >
diff --git a/libavcodec/dpx.c b/libavcodec/dpx.c index bd431ccbcb..12bc165415 100644 --- a/libavcodec/dpx.c +++ b/libavcodec/dpx.c @@ -333,10 +333,12 @@ static int decode_frame(AVCodecContext *avctx, break; case 50: // RGB elements = 3; + yuv = 0; break; case 52: // ABGR case 51: // RGBA elements = 4; + yuv = 0; break; case 100: // UYVY422 elements = 2;
Found by Valgrind. Signed-off-by: James Almer <jamrial@gmail.com> --- libavcodec/dpx.c | 2 ++ 1 file changed, 2 insertions(+)