diff mbox series

[FFmpeg-devel,1/4] avcodec/dolby_e_parser: Remove unused ParseContext

Message ID 20210126164328.1889908-1-andreas.rheinhardt@gmail.com
State Accepted
Commit fa3ab43fecb49d544861a42a03e7432aa829de56
Headers show
Series [FFmpeg-devel,1/4] avcodec/dolby_e_parser: Remove unused ParseContext
Related show

Checks

Context Check Description
andriy/x86_make success Make finished
andriy/x86_make_fate success Make fate finished
andriy/PPC64_make success Make finished
andriy/PPC64_make_fate success Make fate finished

Commit Message

Andreas Rheinhardt Jan. 26, 2021, 4:43 p.m. UTC
Parsers are not forced to use a ParseContext and the other stuff from
parser.h which is just designed to help parsers recombining frames. But
this parser does not do this at all, i.e. the ParseContext is unused.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
---
 libavcodec/dolby_e_parser.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Andreas Rheinhardt Jan. 29, 2021, 4:04 a.m. UTC | #1
Andreas Rheinhardt:
> Parsers are not forced to use a ParseContext and the other stuff from
> parser.h which is just designed to help parsers recombining frames. But
> this parser does not do this at all, i.e. the ParseContext is unused.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
> ---
>  libavcodec/dolby_e_parser.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/libavcodec/dolby_e_parser.c b/libavcodec/dolby_e_parser.c
> index 2c11617906..b7e5db4e6f 100644
> --- a/libavcodec/dolby_e_parser.c
> +++ b/libavcodec/dolby_e_parser.c
> @@ -18,14 +18,11 @@
>   * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
>   */
>  
> -#include "parser.h"
> -
>  #include "dolby_e.h"
>  #include "get_bits.h"
>  #include "put_bits.h"
>  
>  typedef struct DBEParseContext {
> -    ParseContext pc;
>      DBEContext dectx;
>  
>      DolbyEHeaderInfo metadata;
> @@ -74,5 +71,4 @@ AVCodecParser ff_dolby_e_parser = {
>      .codec_ids      = { AV_CODEC_ID_DOLBY_E },
>      .priv_data_size = sizeof(DBEParseContext),
>      .parser_parse   = dolby_e_parse,
> -    .parser_close   = ff_parse_close,
>  };
> 
Will apply tomorrow unless there are objections.

- Andreas
diff mbox series

Patch

diff --git a/libavcodec/dolby_e_parser.c b/libavcodec/dolby_e_parser.c
index 2c11617906..b7e5db4e6f 100644
--- a/libavcodec/dolby_e_parser.c
+++ b/libavcodec/dolby_e_parser.c
@@ -18,14 +18,11 @@ 
  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
  */
 
-#include "parser.h"
-
 #include "dolby_e.h"
 #include "get_bits.h"
 #include "put_bits.h"
 
 typedef struct DBEParseContext {
-    ParseContext pc;
     DBEContext dectx;
 
     DolbyEHeaderInfo metadata;
@@ -74,5 +71,4 @@  AVCodecParser ff_dolby_e_parser = {
     .codec_ids      = { AV_CODEC_ID_DOLBY_E },
     .priv_data_size = sizeof(DBEParseContext),
     .parser_parse   = dolby_e_parse,
-    .parser_close   = ff_parse_close,
 };