diff mbox series

[FFmpeg-devel,1/5] avdevice/alsa_dec: do not set codecpar frame_size

Message ID 20210221164659.19180-1-cus@passwd.hu
State New
Headers show
Series [FFmpeg-devel,1/5] avdevice/alsa_dec: do not set codecpar frame_size
Related show

Checks

Context Check Description
andriy/x86_make success Make finished
andriy/x86_make_fate success Make fate finished
andriy/PPC64_make success Make finished
andriy/PPC64_make_fate success Make fate finished

Commit Message

Marton Balint Feb. 21, 2021, 4:46 p.m. UTC
Constant frame size is not guaranteed if the read call interrupted by a signal,
or if non-blocking mode is used.

Signed-off-by: Marton Balint <cus@passwd.hu>
---
 libavdevice/alsa_dec.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Marton Balint Feb. 27, 2021, 8:58 p.m. UTC | #1
On Sun, 21 Feb 2021, Marton Balint wrote:

> Constant frame size is not guaranteed if the read call interrupted by a signal,
> or if non-blocking mode is used.

Ping for the series.

Thanks,
Marton

>
> Signed-off-by: Marton Balint <cus@passwd.hu>
> ---
> libavdevice/alsa_dec.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/libavdevice/alsa_dec.c b/libavdevice/alsa_dec.c
> index 36494e921c..6d568737b3 100644
> --- a/libavdevice/alsa_dec.c
> +++ b/libavdevice/alsa_dec.c
> @@ -83,7 +83,6 @@ static av_cold int audio_read_header(AVFormatContext *s1)
>     st->codecpar->codec_id    = codec_id;
>     st->codecpar->sample_rate = s->sample_rate;
>     st->codecpar->channels    = s->channels;
> -    st->codecpar->frame_size = s->frame_size;
>     avpriv_set_pts_info(st, 64, 1, 1000000);  /* 64 bits pts in us */
>     /* microseconds instead of seconds, MHz instead of Hz */
>     s->timefilter = ff_timefilter_new(1000000.0 / s->sample_rate,
> -- 
> 2.26.2
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Nicolas George Feb. 28, 2021, 12:58 p.m. UTC | #2
Marton Balint (12021-02-21):
> Constant frame size is not guaranteed if the read call interrupted by a signal,
> or if non-blocking mode is used.
> 
> Signed-off-by: Marton Balint <cus@passwd.hu>
> ---
>  libavdevice/alsa_dec.c | 1 -
>  1 file changed, 1 deletion(-)

Should be ok.

Regards,
diff mbox series

Patch

diff --git a/libavdevice/alsa_dec.c b/libavdevice/alsa_dec.c
index 36494e921c..6d568737b3 100644
--- a/libavdevice/alsa_dec.c
+++ b/libavdevice/alsa_dec.c
@@ -83,7 +83,6 @@  static av_cold int audio_read_header(AVFormatContext *s1)
     st->codecpar->codec_id    = codec_id;
     st->codecpar->sample_rate = s->sample_rate;
     st->codecpar->channels    = s->channels;
-    st->codecpar->frame_size = s->frame_size;
     avpriv_set_pts_info(st, 64, 1, 1000000);  /* 64 bits pts in us */
     /* microseconds instead of seconds, MHz instead of Hz */
     s->timefilter = ff_timefilter_new(1000000.0 / s->sample_rate,