diff mbox series

[FFmpeg-devel,4/4] avcodec/avcodec: Add missing deprecation to AVCodecParser.next

Message ID 20210225140505.1249855-4-andreas.rheinhardt@gmail.com
State Superseded
Headers show
Series [FFmpeg-devel,1/4] avformat/wavenc: Improve unsupported codec error messages
Related show

Checks

Context Check Description
andriy/x86_make_warn warning New warnings during build
andriy/x86_make success Make finished
andriy/x86_make_fate success Make fate finished
andriy/PPC64_make success Make finished
andriy/PPC64_make_fate success Make fate finished

Commit Message

Andreas Rheinhardt Feb. 25, 2021, 2:05 p.m. UTC
The whole old next API has been deprecated in commit
7e8eba2d8755962d9dca5eade57bf8f591a73c0c, yet deprecating the next
pointer has been forgotten (the next pointers of other structures are
below the public API delimiter, but such a delimiter doesn't exist for
AVCodecParser).

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
---
 libavcodec/avcodec.h | 3 +++
 1 file changed, 3 insertions(+)

Comments

James Almer Feb. 25, 2021, 2:13 p.m. UTC | #1
On 2/25/2021 11:05 AM, Andreas Rheinhardt wrote:
> The whole old next API has been deprecated in commit
> 7e8eba2d8755962d9dca5eade57bf8f591a73c0c, yet deprecating the next
> pointer has been forgotten (the next pointers of other structures are
> below the public API delimiter, but such a delimiter doesn't exist for
> AVCodecParser).
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
> ---
>   libavcodec/avcodec.h | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> index 5df6a8aedc..b0cb91f555 100644
> --- a/libavcodec/avcodec.h
> +++ b/libavcodec/avcodec.h
> @@ -3512,7 +3512,10 @@ typedef struct AVCodecParser {
>                           const uint8_t *buf, int buf_size);
>       void (*parser_close)(AVCodecParserContext *s);
>       int (*split)(AVCodecContext *avctx, const uint8_t *buf, int buf_size);
> +#if FF_API_NEXT
> +attribute_deprecated

Adding this will make parsers.c start printing deprecation warnings. Can 
you add the FF_{ENABLE,DISABLE}_DEPRECATION_WARNINGS wrappers there 
while at it?

>       struct AVCodecParser *next;
> +#endif
>   } AVCodecParser;
>   
>   /**
>
diff mbox series

Patch

diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
index 5df6a8aedc..b0cb91f555 100644
--- a/libavcodec/avcodec.h
+++ b/libavcodec/avcodec.h
@@ -3512,7 +3512,10 @@  typedef struct AVCodecParser {
                         const uint8_t *buf, int buf_size);
     void (*parser_close)(AVCodecParserContext *s);
     int (*split)(AVCodecContext *avctx, const uint8_t *buf, int buf_size);
+#if FF_API_NEXT
+attribute_deprecated
     struct AVCodecParser *next;
+#endif
 } AVCodecParser;
 
 /**