diff mbox series

[FFmpeg-devel,01/17] lavu: postpone child_class_next API removal

Message ID 20210405110952.17679-2-anton@khirnov.net
State New
Headers show
Series [FFmpeg-devel,01/17] lavu: postpone child_class_next API removal | expand

Checks

Context Check Description
andriy/x86_make success Make finished
andriy/x86_make_fate success Make fate finished
andriy/PPC64_make success Make finished
andriy/PPC64_make_fate success Make fate finished

Commit Message

Anton Khirnov April 5, 2021, 11:09 a.m. UTC 
It has only been deprecated a year ago.
---
 libavutil/version.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Marton Balint April 5, 2021, 12:32 p.m. UTC | #1 
On Mon, 5 Apr 2021, Anton Khirnov wrote:

> It has only been deprecated a year ago.

Considering that this API has limited public usage, I don't think we have 
to be strict about the 2 years here, so IMHO it is fine to remove it 
at the bump.

Regards,
Marton

> ---
> libavutil/version.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/libavutil/version.h b/libavutil/version.h
> index e88e1ad08d..b97e4e5437 100644
> --- a/libavutil/version.h
> +++ b/libavutil/version.h
> @@ -129,12 +129,12 @@
> #ifndef FF_API_PSEUDOPAL
> #define FF_API_PSEUDOPAL                (LIBAVUTIL_VERSION_MAJOR < 57)
> #endif
> -#ifndef FF_API_CHILD_CLASS_NEXT
> -#define FF_API_CHILD_CLASS_NEXT         (LIBAVUTIL_VERSION_MAJOR < 57)
> -#endif
> #ifndef FF_API_BUFFER_SIZE_T
> #define FF_API_BUFFER_SIZE_T            (LIBAVUTIL_VERSION_MAJOR < 57)
> #endif
> +#ifndef FF_API_CHILD_CLASS_NEXT
> +#define FF_API_CHILD_CLASS_NEXT         (LIBAVUTIL_VERSION_MAJOR < 58)
> +#endif
> #ifndef FF_API_D2STR
> #define FF_API_D2STR                    (LIBAVUTIL_VERSION_MAJOR < 58)
> #endif
> -- 
> 2.30.2
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Anton Khirnov April 8, 2021, 9:06 a.m. UTC | #2 
Quoting Marton Balint (2021-04-05 14:32:54)
> 
> 
> On Mon, 5 Apr 2021, Anton Khirnov wrote:
> 
> > It has only been deprecated a year ago.
> 
> Considering that this API has limited public usage, I don't think we have 
> to be strict about the 2 years here, so IMHO it is fine to remove it 
> at the bump.
> 

Okay, will drop patch if nobody objects.
diff mbox series

Patch

diff --git a/libavutil/version.h b/libavutil/version.h
index e88e1ad08d..b97e4e5437 100644
--- a/libavutil/version.h
+++ b/libavutil/version.h
@@ -129,12 +129,12 @@ 
 #ifndef FF_API_PSEUDOPAL
 #define FF_API_PSEUDOPAL                (LIBAVUTIL_VERSION_MAJOR < 57)
 #endif
-#ifndef FF_API_CHILD_CLASS_NEXT
-#define FF_API_CHILD_CLASS_NEXT         (LIBAVUTIL_VERSION_MAJOR < 57)
-#endif
 #ifndef FF_API_BUFFER_SIZE_T
 #define FF_API_BUFFER_SIZE_T            (LIBAVUTIL_VERSION_MAJOR < 57)
 #endif
+#ifndef FF_API_CHILD_CLASS_NEXT
+#define FF_API_CHILD_CLASS_NEXT         (LIBAVUTIL_VERSION_MAJOR < 58)
+#endif
 #ifndef FF_API_D2STR
 #define FF_API_D2STR                    (LIBAVUTIL_VERSION_MAJOR < 58)
 #endif