diff mbox series

[FFmpeg-devel,2/2] configure: dnn needs avformat

Message ID 20210504122712.868-2-matthias.troffaes@gmail.com
State Accepted
Commit ed409b8088e47c932dcb53edca2d6554348691ba
Headers show
Series [FFmpeg-devel,1/2] configure: fix some filter dependencies | expand

Checks

Context Check Description
andriy/x86_make success Make finished
andriy/x86_make_fate success Make fate finished
andriy/PPC64_make success Make finished
andriy/PPC64_make_fate success Make fate finished

Commit Message

Matthias Troffaes May 4, 2021, 12:27 p.m. UTC 
The source file "libavfilter/dnn/dnn_backend_native.h" includes
"libavformat/avio.h", so avformat needs to be declared as a dependency.
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Guo, Yejun May 6, 2021, 2:53 a.m. UTC | #1 
> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
> Matthias C. M. Troffaes
> Sent: 2021年5月4日 20:27
> To: ffmpeg-devel@ffmpeg.org
> Cc: Matthias C. M. Troffaes <matthias.troffaes@gmail.com>
> Subject: [FFmpeg-devel] [PATCH 2/2] configure: dnn needs avformat
> 
> The source file "libavfilter/dnn/dnn_backend_native.h" includes
> "libavformat/avio.h", so avformat needs to be declared as a dependency.
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 9e45c0822c..8725a94f8a 100755
> --- a/configure
> +++ b/configure
> @@ -2660,7 +2660,7 @@ cbs_vp9_select="cbs"
>  dct_select="rdft"
>  dirac_parse_select="golomb"
>  dnn_suggest="libtensorflow libopenvino"
> -dnn_deps="swscale"
> +dnn_deps="avformat swscale"
>  error_resilience_select="me_cmp"
>  faandct_deps="faan"
>  faandct_select="fdctdsp"
> --
> 2.25.1
> 

thanks for the catch, the native backend uses AVIOContext to load model
from file. Will push this patch soon.
Matthias Troffaes May 9, 2021, 9:45 p.m. UTC | #2 
On Thu, May 6, 2021 at 3:54 AM Guo, Yejun <yejun.guo@intel.com> wrote:
> thanks for the catch, the native backend uses AVIOContext to load model
> from file. Will push this patch soon.

You're welcome. Thanks for accepting!

Kind regards,
Matthias
diff mbox series

Patch

diff --git a/configure b/configure
index 9e45c0822c..8725a94f8a 100755
--- a/configure
+++ b/configure
@@ -2660,7 +2660,7 @@  cbs_vp9_select="cbs"
 dct_select="rdft"
 dirac_parse_select="golomb"
 dnn_suggest="libtensorflow libopenvino"
-dnn_deps="swscale"
+dnn_deps="avformat swscale"
 error_resilience_select="me_cmp"
 faandct_deps="faan"
 faandct_select="fdctdsp"