diff mbox series

[FFmpeg-devel,1/2] lavfi/vf_drawbox.c: fix CID 1485004

Message ID 20210604022246.5193-1-ting.fu@intel.com
State Accepted
Commit 22d99589d8147913a2fad8ba23fca24f6d3f92c3
Headers show
Series [FFmpeg-devel,1/2] lavfi/vf_drawbox.c: fix CID 1485004 | expand

Checks

Context Check Description
andriy/x86_make success Make finished
andriy/x86_make_fate success Make fate finished
andriy/PPC64_make success Make finished
andriy/PPC64_make_fate success Make fate finished

Commit Message

Fu, Ting June 4, 2021, 2:22 a.m. UTC 
CID 1485004: Uninitialized variables (UNINIT)
Using uninitialized value "x" when calling "*pixel_belongs_to_region".

Signed-off-by: Ting Fu <ting.fu@intel.com>
---
 libavfilter/vf_drawbox.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/libavfilter/vf_drawbox.c b/libavfilter/vf_drawbox.c
index fff78862e9..1e9e028650 100644
--- a/libavfilter/vf_drawbox.c
+++ b/libavfilter/vf_drawbox.c
@@ -126,8 +126,9 @@  static void draw_region(AVFrame *frame, DrawBoxContext *ctx, int left, int top,
         for (y = top; y < down; y++) {
             ASSIGN_THREE_CHANNELS
             if (ctx->invert_color) {
-                if (pixel_belongs_to_region(ctx, x, y))
-                    row[0][x] = 0xff - row[0][x];
+                for (x = left; x < right; x++)
+                    if (pixel_belongs_to_region(ctx, x, y))
+                        row[0][x] = 0xff - row[0][x];
             } else {
                 for (x = left; x < right; x++) {
                     double alpha = (double)ctx->yuv_color[A] / 255;