diff mbox series

[FFmpeg-devel,1/2] lavfi/dnn_backend_openvino.c: Fix Memory Leak in execute_model_ov

Message ID 20210711161502.53155-1-shubhanshu.e01@gmail.com
State Accepted
Commit 429954822cd8a74f3ab73f4abe870cf8ef53389b
Headers show
Series [FFmpeg-devel,1/2] lavfi/dnn_backend_openvino.c: Fix Memory Leak in execute_model_ov
Related show

Checks

Context Check Description
andriy/x86_make success Make finished
andriy/x86_make_fate success Make fate finished
andriy/PPC64_make success Make finished
andriy/PPC64_make_fate success Make fate finished

Commit Message

Shubhanshu Saxena July 11, 2021, 4:15 p.m. UTC
In cases where the execution inside the function execute_model_ov fails,
the OVRequestItem must be pushed back to the request_queue before returning
the error. In case pushing back fails, release the allocated memory.

Signed-off-by: Shubhanshu Saxena <shubhanshu.e01@gmail.com>
---
 libavfilter/dnn/dnn_backend_openvino.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/libavfilter/dnn/dnn_backend_openvino.c b/libavfilter/dnn/dnn_backend_openvino.c
index f34b8150f5..b340859c12 100644
--- a/libavfilter/dnn/dnn_backend_openvino.c
+++ b/libavfilter/dnn/dnn_backend_openvino.c
@@ -432,6 +432,8 @@  static DNNReturnType execute_model_ov(RequestItem *request, Queue *inferenceq)
     OVModel *ov_model;
 
     if (ff_queue_size(inferenceq) == 0) {
+        ie_infer_request_free(&request->infer_request);
+        av_freep(&request);
         return DNN_SUCCESS;
     }
 
@@ -443,7 +445,7 @@  static DNNReturnType execute_model_ov(RequestItem *request, Queue *inferenceq)
     if (task->async) {
         ret = fill_model_input_ov(ov_model, request);
         if (ret != DNN_SUCCESS) {
-            return ret;
+            goto err;
         }
         status = ie_infer_set_completion_callback(request->infer_request, &request->callback);
         if (status != OK) {
@@ -459,7 +461,7 @@  static DNNReturnType execute_model_ov(RequestItem *request, Queue *inferenceq)
     } else {
         ret = fill_model_input_ov(ov_model, request);
         if (ret != DNN_SUCCESS) {
-            return ret;
+            goto err;
         }
         status = ie_infer_request_infer(request->infer_request);
         if (status != OK) {