| Message ID | 20211215204747.54229-1-ffmpeg@haasn.xyz |
|---|---|
| State | New |
| Headers | show |
| Series | [FFmpeg-devel] lavfi/vf_libplacebo: update deprecated option name | expand |
| Context | Check | Description |
|---|---|---|
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
| andriy/make_ppc | success | Make finished |
| andriy/make_fate_ppc | success | Make fate finished |
15 Dec 2021, 21:47 by ffmpeg@haasn.xyz: > From: Niklas Haas <git@haasn.dev> > > This was renamed upstream quite a while ago (v3.112.0). Keep the old > option name in libavfilter for backwards compatibility. > > Signed-off-by: Niklas Haas <git@haasn.dev> > --- > libavfilter/vf_libplacebo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/vf_libplacebo.c b/libavfilter/vf_libplacebo.c > index 7ece9d829e..515fd44d24 100644 > --- a/libavfilter/vf_libplacebo.c > +++ b/libavfilter/vf_libplacebo.c > @@ -357,7 +357,7 @@ static int process_frames(AVFilterContext *avctx, AVFrame *out, AVFrame *in) > .polar_cutoff = s->polar_cutoff, > .disable_linear_scaling = s->disable_linear, > .disable_builtin_scalers = s->disable_builtin, > - .force_3dlut = s->force_3dlut, > + .force_icc_lut = s->force_3dlut, > .force_dither = s->force_dither, > .disable_fbos = s->disable_fbos, > }; > Since the filter was merged quite recently, and we haven't made a release yet, I think it's fine to break CLI compatibility. Could you rename the option as well?
diff --git a/libavfilter/vf_libplacebo.c b/libavfilter/vf_libplacebo.c index 7ece9d829e..515fd44d24 100644 --- a/libavfilter/vf_libplacebo.c +++ b/libavfilter/vf_libplacebo.c @@ -357,7 +357,7 @@ static int process_frames(AVFilterContext *avctx, AVFrame *out, AVFrame *in) .polar_cutoff = s->polar_cutoff, .disable_linear_scaling = s->disable_linear, .disable_builtin_scalers = s->disable_builtin, - .force_3dlut = s->force_3dlut, + .force_icc_lut = s->force_3dlut, .force_dither = s->force_dither, .disable_fbos = s->disable_fbos, };