diff mbox series

[FFmpeg-devel] avformat/riff: add more GeoVision FOURCC

Message ID 20220217100138.245991-1-thomas@gllm.fr
State New
Headers show
Series [FFmpeg-devel] avformat/riff: add more GeoVision FOURCC | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished
andriy/make_aarch64_jetson success Make finished
andriy/make_fate_aarch64_jetson success Make fate finished
andriy/make_ppc success Make finished
andriy/make_fate_ppc success Make fate finished

Commit Message

Thomas Guillem Feb. 17, 2022, 10:01 a.m. UTC 
---
 libavformat/riff.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Michael Niedermayer Feb. 17, 2022, 2:32 p.m. UTC | #1 
On Thu, Feb 17, 2022 at 11:01:38AM +0100, Thomas Guillem wrote:
> ---
>  libavformat/riff.c | 2 ++
>  1 file changed, 2 insertions(+)

please provide a link or sample file for these

the change itself should be ok

thx

[...]
Thomas Guillem Feb. 17, 2022, 3:19 p.m. UTC | #2 
Hello,

Sorry, but I'm not allowed to share these cameras' footage.

I was able to test them, and it runs fine on last ffmpeg.

On Thu, Feb 17, 2022, at 15:32, Michael Niedermayer wrote:
> On Thu, Feb 17, 2022 at 11:01:38AM +0100, Thomas Guillem wrote:
>> ---
>>  libavformat/riff.c | 2 ++
>>  1 file changed, 2 insertions(+)
>
> please provide a link or sample file for these
>
> the change itself should be ok
>
> thx
>
> [...]
> -- 
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Awnsering whenever a program halts or runs forever is
> On a turing machine, in general impossible (turings halting problem).
> On any real computer, always possible as a real computer has a finite number
> of states N, and will either halt in less than N cycles or never halt.
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
> Attachments:
> * signature.asc
diff mbox series

Patch

diff --git a/libavformat/riff.c b/libavformat/riff.c
index 27a9706510..23e6306b66 100644
--- a/libavformat/riff.c
+++ b/libavformat/riff.c
@@ -32,6 +32,7 @@ 
  * files use it as well.
  */
 const AVCodecTag ff_codec_bmp_tags[] = {
+    { AV_CODEC_ID_H265,         MKTAG('G', 'H', 'E', 'C') }, /* GeoVision camera */
     { AV_CODEC_ID_H264,         MKTAG('H', '2', '6', '4') },
     { AV_CODEC_ID_H264,         MKTAG('h', '2', '6', '4') },
     { AV_CODEC_ID_H264,         MKTAG('X', '2', '6', '4') },
@@ -115,6 +116,7 @@  const AVCodecTag ff_codec_bmp_tags[] = {
     { AV_CODEC_ID_MPEG4,        MKTAG('P', 'L', 'V', '1') }, /* Pelco DVR MPEG-4 */
     { AV_CODEC_ID_MPEG4,        MKTAG('G', 'L', 'V', '4') },
     { AV_CODEC_ID_MPEG4,        MKTAG('G', 'M', 'P', '4') }, /* GeoVision camera */
+    { AV_CODEC_ID_MPEG4,        MKTAG('G', 'M', '4', '0') }, /* GeoVision camera */
     { AV_CODEC_ID_MPEG4,        MKTAG('M', 'N', 'M', '4') }, /* March Networks DVR */
     { AV_CODEC_ID_MPEG4,        MKTAG('G', 'T', 'M', '4') }, /* Telefactor */
     { AV_CODEC_ID_MSMPEG4V3,    MKTAG('M', 'P', '4', '3') },