diff mbox series

[FFmpeg-devel] Makefile: avoid cp-ing over existing executable files

Message ID 20220525050047.26388-1-rcombs@rcombs.me
State Accepted
Commit bb6d9a0f326c3ba8ddbba28fdf9ca70759db99aa
Headers show
Series [FFmpeg-devel] Makefile: avoid cp-ing over existing executable files | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished
andriy/make_armv7_RPi4 success Make finished
andriy/make_fate_armv7_RPi4 success Make fate finished

Commit Message

Ridley Combs May 25, 2022, 5 a.m. UTC
On macOS, code-signing information for executables (including those signed
automatically by the linker) is cached by the system on a per-inode basis.
The cp(1) tool will truncate and overwrite an existing file if present,
so we need to delete it first to avoid strange crashes.

See https://developer.apple.com/documentation/security/updating_mac_software
---
 Makefile | 1 +
 1 file changed, 1 insertion(+)
diff mbox series

Patch

diff --git a/Makefile b/Makefile
index 48cfb6e240..95473beec1 100644
--- a/Makefile
+++ b/Makefile
@@ -119,6 +119,7 @@  $(PROGS): %$(PROGSSUF)$(EXESUF): %$(PROGSSUF)_g$(EXESUF)
 ifeq ($(STRIPTYPE),direct)
 	$(STRIP) -o $@ $<
 else
+	$(RM) $@
 	$(CP) $< $@
 	$(STRIP) $@
 endif