| Message ID | 20220623121436.58517-1-rgonzalez@fluendo.com |
|---|---|
| State | Accepted |
| Commit | 2d8d7f859216dbddcb72ad2cba9d5e8489304e32 |
| Headers | show |
| Series | [FFmpeg-devel] avformat: allow .ec3 as extension for raw E-AC-3 stream | expand |
| Context | Check | Description |
|---|---|---|
| yinshiyou/make_fate_loongarch64 | success | Make fate finished |
| yinshiyou/make_loongarch64 | warning | New warnings during build |
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
| andriy/make_armv7_RPi4 | success | Make finished |
| andriy/make_fate_armv7_RPi4 | success | Make fate finished |
Hello community, please, Let me know if something is pending to start the review process. On Thu, Jun 23, 2022 at 2:14 PM Ruben Gonzalez <rgonzalez@fluendo.com> wrote: > In addition to .eac3, .ec3 is also commonly used by people to name raw > E-AC-3 streams. Enables automatic recognition of the eac3 format for > the .ac3 extension. > > For instance Dolby Digital Plus software only support files with > .ec3. Files with .eac3 are not supported. Check issue #18 in the > public dlb_mp4base repository from DolbyLaboratories. > > Signed-off-by: Ruben Gonzalez <rgonzalez@fluendo.com> > --- > libavformat/ac3dec.c | 2 +- > libavformat/rawenc.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavformat/ac3dec.c b/libavformat/ac3dec.c > index 51461befd8..989d126a81 100644 > --- a/libavformat/ac3dec.c > +++ b/libavformat/ac3dec.c > @@ -131,7 +131,7 @@ const AVInputFormat ff_eac3_demuxer = { > .read_header = ff_raw_audio_read_header, > .read_packet = ff_raw_read_partial_packet, > .flags = AVFMT_GENERIC_INDEX, > - .extensions = "eac3", > + .extensions = "eac3,ec3", > .raw_codec_id = AV_CODEC_ID_EAC3, > .priv_data_size = sizeof(FFRawDemuxerContext), > .priv_class = &ff_raw_demuxer_class, > diff --git a/libavformat/rawenc.c b/libavformat/rawenc.c > index 26099cb1c1..267fce252d 100644 > --- a/libavformat/rawenc.c > +++ b/libavformat/rawenc.c > @@ -252,7 +252,7 @@ const AVOutputFormat ff_eac3_muxer = { > .name = "eac3", > .long_name = NULL_IF_CONFIG_SMALL("raw E-AC-3"), > .mime_type = "audio/x-eac3", > - .extensions = "eac3", > + .extensions = "eac3,ec3", > .audio_codec = AV_CODEC_ID_EAC3, > .video_codec = AV_CODEC_ID_NONE, > .init = force_one_stream, > -- > 2.25.1 > >
Looks reasonable, will push soonish if nobody objects.
Ok, thanks. On Thu, Aug 4, 2022 at 12:42 PM Anton Khirnov <anton@khirnov.net> wrote: > Looks reasonable, will push soonish if nobody objects. > > -- > Anton Khirnov >
diff --git a/libavformat/ac3dec.c b/libavformat/ac3dec.c index 51461befd8..989d126a81 100644 --- a/libavformat/ac3dec.c +++ b/libavformat/ac3dec.c @@ -131,7 +131,7 @@ const AVInputFormat ff_eac3_demuxer = { .read_header = ff_raw_audio_read_header, .read_packet = ff_raw_read_partial_packet, .flags = AVFMT_GENERIC_INDEX, - .extensions = "eac3", + .extensions = "eac3,ec3", .raw_codec_id = AV_CODEC_ID_EAC3, .priv_data_size = sizeof(FFRawDemuxerContext), .priv_class = &ff_raw_demuxer_class, diff --git a/libavformat/rawenc.c b/libavformat/rawenc.c index 26099cb1c1..267fce252d 100644 --- a/libavformat/rawenc.c +++ b/libavformat/rawenc.c @@ -252,7 +252,7 @@ const AVOutputFormat ff_eac3_muxer = { .name = "eac3", .long_name = NULL_IF_CONFIG_SMALL("raw E-AC-3"), .mime_type = "audio/x-eac3", - .extensions = "eac3", + .extensions = "eac3,ec3", .audio_codec = AV_CODEC_ID_EAC3, .video_codec = AV_CODEC_ID_NONE, .init = force_one_stream,
In addition to .eac3, .ec3 is also commonly used by people to name raw E-AC-3 streams. Enables automatic recognition of the eac3 format for the .ac3 extension. For instance Dolby Digital Plus software only support files with .ec3. Files with .eac3 are not supported. Check issue #18 in the public dlb_mp4base repository from DolbyLaboratories. Signed-off-by: Ruben Gonzalez <rgonzalez@fluendo.com> --- libavformat/ac3dec.c | 2 +- libavformat/rawenc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)