@@ -65,10 +65,12 @@ do { \
char *next, *cur = str; \
int ret; \
\
- while (cur) { \
+ if (!cur) \
+ break; \
+ while (*cur) { \
type fmt; \
- next = strchr(cur, '|'); \
- if (next) \
+ next = ff_formats_list_find_delimiter(cur); \
+ if (*next) \
*next++ = 0; \
\
if ((fmt = get_fmt(cur)) == none) { \
@@ -405,4 +405,13 @@ int ff_filter_process_command(AVFilterContext *ctx, const char *cmd,
int ff_filter_init_hw_frames(AVFilterContext *avctx, AVFilterLink *link,
int default_pool_size);
+/**
+ * Find the next delimiter in a string of formats.
+ * The delimiter is '|' or the end of the string.
+ */
+static inline char *ff_formats_list_find_delimiter(const char *str)
+{
+ return (char *)str + strcspn(str, "|");
+}
+
#endif /* AVFILTER_INTERNAL_H */
@@ -69,10 +69,9 @@ static av_cold int init(AVFilterContext *ctx)
/* count the formats */
cur = s->pix_fmts;
- while ((cur = strchr(cur, '|'))) {
+ while (*(cur = ff_formats_list_find_delimiter(cur))) {
nb_formats++;
- if (*cur)
- cur++;
+ cur++;
}
s->formats = av_malloc_array(nb_formats + 1, sizeof(*s->formats));
@@ -82,8 +81,8 @@ static av_cold int init(AVFilterContext *ctx)
/* parse the list of formats */
cur = s->pix_fmts;
for (i = 0; i < nb_formats; i++) {
- sep = strchr(cur, '|');
- if (sep)
+ sep = ff_formats_list_find_delimiter(cur);
+ if (*sep)
*sep++ = 0;
if ((ret = ff_parse_pixel_format(&s->formats[i], cur, ctx)) < 0)
Signed-off-by: Nicolas George <george@nsup.org> --- libavfilter/af_aformat.c | 8 +++++--- libavfilter/internal.h | 9 +++++++++ libavfilter/vf_format.c | 9 ++++----- 3 files changed, 18 insertions(+), 8 deletions(-) Identical to the one posted months ago.