diff mbox series

[FFmpeg-devel,2/3] avcodec/raw: add VUYA pixel format to raw_pix_fmt_tags

Message ID 20220807003456.54933-1-jamrial@gmail.com
State New
Headers show
Series [FFmpeg-devel] swscale/output: add VUYA output support | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 fail Make fate failed
andriy/make_x86 success Make finished
andriy/make_fate_x86 fail Make fate failed

Commit Message

James Almer Aug. 7, 2022, 12:34 a.m. UTC
Signed-off-by: James Almer <jamrial@gmail.com>
---
 libavcodec/raw.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Michael Niedermayer Aug. 7, 2022, 11:39 a.m. UTC | #1
On Sat, Aug 06, 2022 at 09:34:55PM -0300, James Almer wrote:
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>  libavcodec/raw.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/libavcodec/raw.c b/libavcodec/raw.c
> index a371bb36c4..1e5b48d1e0 100644
> --- a/libavcodec/raw.c
> +++ b/libavcodec/raw.c
> @@ -72,6 +72,7 @@ static const PixelFormatTag raw_pix_fmt_tags[] = {
>      { AV_PIX_FMT_GRAY8,   MKTAG('G', 'R', 'E', 'Y') },
>      { AV_PIX_FMT_NV12,    MKTAG('N', 'V', '1', '2') },
>      { AV_PIX_FMT_NV21,    MKTAG('N', 'V', '2', '1') },
> +    { AV_PIX_FMT_VUYA,    MKTAG('A', 'Y', 'U', 'V') }, /* MS 4:4:4:4 */
>  
>      /* nut */
>      { AV_PIX_FMT_RGB555LE, MKTAG('R', 'G', 'B', 15) },

iam possibly missing some patch but this seems failing here

TEST    filter-pixfmts-scale
--- ./tests/ref/fate/filter-pixfmts-scale	2022-08-07 13:23:20.154330375 +0200
+++ tests/data/fate/filter-pixfmts-scale	2022-08-07 13:36:27.701410658 +0200
@@ -89,7 +89,7 @@
 rgba64be            ee73e57923af984b31cc7795d13929da
 rgba64le            783d2779adfafe3548bdb671ec0de69e
 uyvy422             aeb4ba4f9f003ae21f6d18089198244f
-vuya                ab4c9c4a6b6946945eeb23e15d0341b0
+vuya                d41d8cd98f00b204e9800998ecf8427e
 x2bgr10le           d57b9a99033cc7b65ddd111578f2d385
 x2rgb10le           d56bdb23fa6a8e12a0b4394987f89935
 xyz12be             c7ba8345998c0141ddc079cdd29b1a40
Test filter-pixfmts-scale failed. Look at tests/data/fate/filter-pixfmts-scale.err for details.
tests/Makefile:304: recipe for target 'fate-filter-pixfmts-scale' failed
make: *** [fate-filter-pixfmts-scale] Error 1

[...]
James Almer Aug. 7, 2022, 11:56 a.m. UTC | #2
On 8/7/2022 8:39 AM, Michael Niedermayer wrote:
> On Sat, Aug 06, 2022 at 09:34:55PM -0300, James Almer wrote:
>> Signed-off-by: James Almer <jamrial@gmail.com>
>> ---
>>   libavcodec/raw.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/libavcodec/raw.c b/libavcodec/raw.c
>> index a371bb36c4..1e5b48d1e0 100644
>> --- a/libavcodec/raw.c
>> +++ b/libavcodec/raw.c
>> @@ -72,6 +72,7 @@ static const PixelFormatTag raw_pix_fmt_tags[] = {
>>       { AV_PIX_FMT_GRAY8,   MKTAG('G', 'R', 'E', 'Y') },
>>       { AV_PIX_FMT_NV12,    MKTAG('N', 'V', '1', '2') },
>>       { AV_PIX_FMT_NV21,    MKTAG('N', 'V', '2', '1') },
>> +    { AV_PIX_FMT_VUYA,    MKTAG('A', 'Y', 'U', 'V') }, /* MS 4:4:4:4 */
>>   
>>       /* nut */
>>       { AV_PIX_FMT_RGB555LE, MKTAG('R', 'G', 'B', 15) },
> 
> iam possibly missing some patch but this seems failing here
> 
> TEST    filter-pixfmts-scale
> --- ./tests/ref/fate/filter-pixfmts-scale	2022-08-07 13:23:20.154330375 +0200
> +++ tests/data/fate/filter-pixfmts-scale	2022-08-07 13:36:27.701410658 +0200
> @@ -89,7 +89,7 @@
>   rgba64be            ee73e57923af984b31cc7795d13929da
>   rgba64le            783d2779adfafe3548bdb671ec0de69e
>   uyvy422             aeb4ba4f9f003ae21f6d18089198244f
> -vuya                ab4c9c4a6b6946945eeb23e15d0341b0
> +vuya                d41d8cd98f00b204e9800998ecf8427e
>   x2bgr10le           d57b9a99033cc7b65ddd111578f2d385
>   x2rgb10le           d56bdb23fa6a8e12a0b4394987f89935
>   xyz12be             c7ba8345998c0141ddc079cdd29b1a40
> Test filter-pixfmts-scale failed. Look at tests/data/fate/filter-pixfmts-scale.err for details.
> tests/Makefile:304: recipe for target 'fate-filter-pixfmts-scale' failed

Yes, forgot to ran fate after these last two patches. All the 
filter-pixfmts tests are affected, and the change is because the nut 
output the md5 sum is calculated from changed to include the fourcc 
"AYUV" instead of "RGB" that was being used before this set.

I'll also squash this and patch 3/3 before pushing.
diff mbox series

Patch

diff --git a/libavcodec/raw.c b/libavcodec/raw.c
index a371bb36c4..1e5b48d1e0 100644
--- a/libavcodec/raw.c
+++ b/libavcodec/raw.c
@@ -72,6 +72,7 @@  static const PixelFormatTag raw_pix_fmt_tags[] = {
     { AV_PIX_FMT_GRAY8,   MKTAG('G', 'R', 'E', 'Y') },
     { AV_PIX_FMT_NV12,    MKTAG('N', 'V', '1', '2') },
     { AV_PIX_FMT_NV21,    MKTAG('N', 'V', '2', '1') },
+    { AV_PIX_FMT_VUYA,    MKTAG('A', 'Y', 'U', 'V') }, /* MS 4:4:4:4 */
 
     /* nut */
     { AV_PIX_FMT_RGB555LE, MKTAG('R', 'G', 'B', 15) },