diff mbox series

[FFmpeg-devel,v1] avfilter/af_loudnorm: fix incorrect gain when audio is shorter than 3s

Message ID 20220831125106.21978-1-real.zhurui@gmail.com
State Accepted
Commit 36572a0c1d12459cb0fddf6ff8023b79ffa2e100
Headers show
Series [FFmpeg-devel,v1] avfilter/af_loudnorm: fix incorrect gain when audio is shorter than 3s | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

real.zhurui@gmail.com Aug. 31, 2022, 12:51 p.m. UTC 
From: Rui Zhu <real.zhurui@gmail.com>

The input data is multiplied by `s->offset` to get normalized output.
`s->target_tp` and `true_peak` is not in dB,
so `s->offset` should be calculated by division instead of subtraction.

Signed-off-by: Rui Zhu <real.zhurui@gmail.com>
---
 libavfilter/af_loudnorm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/libavfilter/af_loudnorm.c b/libavfilter/af_loudnorm.c
index 8d2379f14e..ce61e985b1 100644
--- a/libavfilter/af_loudnorm.c
+++ b/libavfilter/af_loudnorm.c
@@ -455,7 +455,7 @@  static int filter_frame(AVFilterLink *inlink, AVFrame *in)
 
         offset    = pow(10., (s->target_i - global) / 20.);
         offset_tp = true_peak * offset;
-        s->offset = offset_tp < s->target_tp ? offset : s->target_tp - true_peak;
+        s->offset = offset_tp < s->target_tp ? offset : s->target_tp / true_peak;
         s->frame_type = LINEAR_MODE;
     }