diff mbox series

[FFmpeg-devel,avcodec/amfenc:,10,bit,support,v2,1/3] amf: Update the min version to 1.4.23.0 for AMF SDK.

Message ID 20220907134122.1244-1-ovchinnikov.dmitrii@gmail.com
State New
Headers show
Series [FFmpeg-devel,avcodec/amfenc:,10,bit,support,v2,1/3] amf: Update the min version to 1.4.23.0 for AMF SDK. | expand

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Dmitrii Ovchinnikov Sept. 7, 2022, 1:41 p.m. UTC 
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jean-Baptiste Kempf Sept. 7, 2022, 7:59 p.m. UTC | #1 
Isn't that a bit too recent? Or does it not matter because it still supports old drivers?

jb

On Wed, 7 Sep 2022, at 15:41, OvchinnikovDmitrii wrote:
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 9e51abd0d3..a644e17c95 100755
> --- a/configure
> +++ b/configure
> @@ -7038,7 +7038,7 @@ fi
> 
>  enabled amf &&
>      check_cpp_condition amf "AMF/core/Version.h" \
> -        "(AMF_VERSION_MAJOR << 48 | AMF_VERSION_MINOR << 32 | 
> AMF_VERSION_RELEASE << 16 | AMF_VERSION_BUILD_NUM) >= 
> 0x0001000400090000"
> +        "(AMF_VERSION_MAJOR << 48 | AMF_VERSION_MINOR << 32 | 
> AMF_VERSION_RELEASE << 16 | AMF_VERSION_BUILD_NUM) >= 
> 0x0001000400170000"
> 
>  # Funny iconv installations are not unusual, so check it after all 
> flags have been set
>  if enabled libc_iconv; then
> -- 
> 2.30.0.windows.2
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Dmitrii Ovchinnikov Sept. 7, 2022, 10:54 p.m. UTC | #2 
>>Isn't that a bit too recent? Or does it not matter because it still
supports old drivers?

Old drivers are fully supported.
Dmitrii Ovchinnikov Oct. 25, 2022, 3:56 p.m. UTC | #3 
Hi! These patches have already been tested and accepted into the  HandBrake
  (https://github.com/HandBrake/HandBrake/pull/4538 ). Could you take a
look?
diff mbox series

Patch

diff --git a/configure b/configure
index 9e51abd0d3..a644e17c95 100755
--- a/configure
+++ b/configure
@@ -7038,7 +7038,7 @@  fi
 
 enabled amf &&
     check_cpp_condition amf "AMF/core/Version.h" \
-        "(AMF_VERSION_MAJOR << 48 | AMF_VERSION_MINOR << 32 | AMF_VERSION_RELEASE << 16 | AMF_VERSION_BUILD_NUM) >= 0x0001000400090000"
+        "(AMF_VERSION_MAJOR << 48 | AMF_VERSION_MINOR << 32 | AMF_VERSION_RELEASE << 16 | AMF_VERSION_BUILD_NUM) >= 0x0001000400170000"
 
 # Funny iconv installations are not unusual, so check it after all flags have been set
 if enabled libc_iconv; then