| Message ID | 20220908195737.1618147-1-tmatth@videolan.org |
|---|---|
| State | Accepted |
| Commit | 1d326e91875bcc9b9e0e907f5b94842172e66ec8 |
| Headers | show |
| Series | [FFmpeg-devel,1/1] fate/opus: add silk LBRR test (refs #9890) | expand |
| Context | Check | Description |
|---|---|---|
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | fail | Make fate failed |
On Thu, Sep 8, 2022 at 3:58 PM Tristan Matthews <tmatth@videolan.org> wrote: > This adds a fate test for a sample with LBRR packets. > > It requires that these files be uploaded: > https://people.videolan.org/~tmatth/9890-fate/silk-lbrr.mka > https://people.videolan.org/~tmatth/9890-fate/silk-lbrr.dec > > --- > tests/fate/opus.mak | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tests/fate/opus.mak b/tests/fate/opus.mak > index 573044ed15..7d359f414a 100644 > --- a/tests/fate/opus.mak > +++ b/tests/fate/opus.mak > @@ -4,7 +4,7 @@ > > OPUS_CELT_SAMPLES = $(addprefix testvector, 01 11) tron.6ch.tinypkts > OPUS_HYBRID_SAMPLES = $(addprefix testvector, 05 06) > -OPUS_SILK_SAMPLES = $(addprefix testvector, 02 03 04) > +OPUS_SILK_SAMPLES = $(addprefix testvector, 02 03 04) silk-lbrr > OPUS_OTHER_SAMPLES = $(addprefix testvector, 07 08 09 10 12) > > define FATE_OPUS_TEST > @@ -33,6 +33,7 @@ fate-opus-testvector09: CMP_TARGET = 0 > fate-opus-testvector10: CMP_TARGET = 38 > fate-opus-testvector11: CMP_TARGET = 0 > fate-opus-testvector12: CMP_TARGET = 160 > +fate-opus-silk-lbrr: CMP_TARGET = 0 > fate-opus-tron.6ch.tinypkts: CMP_SHIFT = 1440 > fate-opus-tron.6ch.tinypkts: CMP_TARGET = 0 > > -- > 2.34.1 > Sorry this was supposed to be in response to http://ffmpeg.org/pipermail/ffmpeg-devel/2022-August/300758.html (as it depends on it) but I screwed up the git-send-email. Best, -t
Tristan Matthews: > On Thu, Sep 8, 2022 at 3:58 PM Tristan Matthews <tmatth@videolan.org> wrote: > >> This adds a fate test for a sample with LBRR packets. >> >> It requires that these files be uploaded: >> https://people.videolan.org/~tmatth/9890-fate/silk-lbrr.mka >> https://people.videolan.org/~tmatth/9890-fate/silk-lbrr.dec >> >> --- >> tests/fate/opus.mak | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/tests/fate/opus.mak b/tests/fate/opus.mak >> index 573044ed15..7d359f414a 100644 >> --- a/tests/fate/opus.mak >> +++ b/tests/fate/opus.mak >> @@ -4,7 +4,7 @@ >> >> OPUS_CELT_SAMPLES = $(addprefix testvector, 01 11) tron.6ch.tinypkts >> OPUS_HYBRID_SAMPLES = $(addprefix testvector, 05 06) >> -OPUS_SILK_SAMPLES = $(addprefix testvector, 02 03 04) >> +OPUS_SILK_SAMPLES = $(addprefix testvector, 02 03 04) silk-lbrr >> OPUS_OTHER_SAMPLES = $(addprefix testvector, 07 08 09 10 12) >> >> define FATE_OPUS_TEST >> @@ -33,6 +33,7 @@ fate-opus-testvector09: CMP_TARGET = 0 >> fate-opus-testvector10: CMP_TARGET = 38 >> fate-opus-testvector11: CMP_TARGET = 0 >> fate-opus-testvector12: CMP_TARGET = 160 >> +fate-opus-silk-lbrr: CMP_TARGET = 0 >> fate-opus-tron.6ch.tinypkts: CMP_SHIFT = 1440 >> fate-opus-tron.6ch.tinypkts: CMP_TARGET = 0 >> >> -- >> 2.34.1 >> > > > Sorry this was supposed to be in response to > http://ffmpeg.org/pipermail/ffmpeg-devel/2022-August/300758.html (as it > depends on it) but I screwed up the git-send-email. > Does this sample have to be so long? - Andreas
On Fri, Sep 23, 2022 at 8:15 AM Andreas Rheinhardt <andreas.rheinhardt@outlook.com> wrote: > > Tristan Matthews: > > On Thu, Sep 8, 2022 at 3:58 PM Tristan Matthews <tmatth@videolan.org> wrote: > > > >> This adds a fate test for a sample with LBRR packets. > >> > >> It requires that these files be uploaded: > >> https://people.videolan.org/~tmatth/9890-fate/silk-lbrr.mka > >> https://people.videolan.org/~tmatth/9890-fate/silk-lbrr.dec > >> > >> --- > >> tests/fate/opus.mak | 3 ++- > >> 1 file changed, 2 insertions(+), 1 deletion(-) > >> > >> diff --git a/tests/fate/opus.mak b/tests/fate/opus.mak > >> index 573044ed15..7d359f414a 100644 > >> --- a/tests/fate/opus.mak > >> +++ b/tests/fate/opus.mak > >> @@ -4,7 +4,7 @@ > >> > >> OPUS_CELT_SAMPLES = $(addprefix testvector, 01 11) tron.6ch.tinypkts > >> OPUS_HYBRID_SAMPLES = $(addprefix testvector, 05 06) > >> -OPUS_SILK_SAMPLES = $(addprefix testvector, 02 03 04) > >> +OPUS_SILK_SAMPLES = $(addprefix testvector, 02 03 04) silk-lbrr > >> OPUS_OTHER_SAMPLES = $(addprefix testvector, 07 08 09 10 12) > >> > >> define FATE_OPUS_TEST > >> @@ -33,6 +33,7 @@ fate-opus-testvector09: CMP_TARGET = 0 > >> fate-opus-testvector10: CMP_TARGET = 38 > >> fate-opus-testvector11: CMP_TARGET = 0 > >> fate-opus-testvector12: CMP_TARGET = 160 > >> +fate-opus-silk-lbrr: CMP_TARGET = 0 > >> fate-opus-tron.6ch.tinypkts: CMP_SHIFT = 1440 > >> fate-opus-tron.6ch.tinypkts: CMP_TARGET = 0 > >> > >> -- > >> 2.34.1 > >> > > > > > > Sorry this was supposed to be in response to > > http://ffmpeg.org/pipermail/ffmpeg-devel/2022-August/300758.html (as it > > depends on it) but I screwed up the git-send-email. > > > > Does this sample have to be so long? I've shortened it from 4 seconds to 1 second (which is still long enough to hear the bug when using an older build). Note that most of the opus test vectors are on the order of 25 seconds. Best, Tristan > > - Andreas > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
On Fri, Sep 23, 2022 at 3:04 PM Tristan Matthews <tmatth@videolan.org> wrote: > > On Fri, Sep 23, 2022 at 8:15 AM Andreas Rheinhardt > <andreas.rheinhardt@outlook.com> wrote: > > > > Tristan Matthews: > > > On Thu, Sep 8, 2022 at 3:58 PM Tristan Matthews <tmatth@videolan.org> wrote: > > > > > >> This adds a fate test for a sample with LBRR packets. > > >> > > >> It requires that these files be uploaded: > > >> https://people.videolan.org/~tmatth/9890-fate/silk-lbrr.mka > > >> https://people.videolan.org/~tmatth/9890-fate/silk-lbrr.dec > > >> > > >> --- > > >> tests/fate/opus.mak | 3 ++- > > >> 1 file changed, 2 insertions(+), 1 deletion(-) > > >> > > >> diff --git a/tests/fate/opus.mak b/tests/fate/opus.mak > > >> index 573044ed15..7d359f414a 100644 > > >> --- a/tests/fate/opus.mak > > >> +++ b/tests/fate/opus.mak > > >> @@ -4,7 +4,7 @@ > > >> > > >> OPUS_CELT_SAMPLES = $(addprefix testvector, 01 11) tron.6ch.tinypkts > > >> OPUS_HYBRID_SAMPLES = $(addprefix testvector, 05 06) > > >> -OPUS_SILK_SAMPLES = $(addprefix testvector, 02 03 04) > > >> +OPUS_SILK_SAMPLES = $(addprefix testvector, 02 03 04) silk-lbrr > > >> OPUS_OTHER_SAMPLES = $(addprefix testvector, 07 08 09 10 12) > > >> > > >> define FATE_OPUS_TEST > > >> @@ -33,6 +33,7 @@ fate-opus-testvector09: CMP_TARGET = 0 > > >> fate-opus-testvector10: CMP_TARGET = 38 > > >> fate-opus-testvector11: CMP_TARGET = 0 > > >> fate-opus-testvector12: CMP_TARGET = 160 > > >> +fate-opus-silk-lbrr: CMP_TARGET = 0 > > >> fate-opus-tron.6ch.tinypkts: CMP_SHIFT = 1440 > > >> fate-opus-tron.6ch.tinypkts: CMP_TARGET = 0 > > >> > > >> -- > > >> 2.34.1 > > >> > > > > > > > > > Sorry this was supposed to be in response to > > > http://ffmpeg.org/pipermail/ffmpeg-devel/2022-August/300758.html (as it > > > depends on it) but I screwed up the git-send-email. > > > > > > > Does this sample have to be so long? > > I've shortened it from 4 seconds to 1 second (which is still long > enough to hear the bug when using an older build). > Note that most of the opus test vectors are on the order of 25 seconds. These shorter samples have been updated by James Almer, so this patch is good to go Best, -t > > Best, > Tristan > > > > > - Andreas > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Quoting Tristan Matthews (2022-09-30 15:53:48) > These shorter samples have been updated by James Almer, so this patch > is good to go Will push soonish. Thanks for the patches.
diff --git a/tests/fate/opus.mak b/tests/fate/opus.mak index 573044ed15..7d359f414a 100644 --- a/tests/fate/opus.mak +++ b/tests/fate/opus.mak @@ -4,7 +4,7 @@ OPUS_CELT_SAMPLES = $(addprefix testvector, 01 11) tron.6ch.tinypkts OPUS_HYBRID_SAMPLES = $(addprefix testvector, 05 06) -OPUS_SILK_SAMPLES = $(addprefix testvector, 02 03 04) +OPUS_SILK_SAMPLES = $(addprefix testvector, 02 03 04) silk-lbrr OPUS_OTHER_SAMPLES = $(addprefix testvector, 07 08 09 10 12) define FATE_OPUS_TEST @@ -33,6 +33,7 @@ fate-opus-testvector09: CMP_TARGET = 0 fate-opus-testvector10: CMP_TARGET = 38 fate-opus-testvector11: CMP_TARGET = 0 fate-opus-testvector12: CMP_TARGET = 160 +fate-opus-silk-lbrr: CMP_TARGET = 0 fate-opus-tron.6ch.tinypkts: CMP_SHIFT = 1440 fate-opus-tron.6ch.tinypkts: CMP_TARGET = 0