diff mbox series

[FFmpeg-devel] avformat/riffdec: don't unconditionally overwrite WAVEFORMATEXTENSIBLE layout

Message ID 20220910120540.718-1-jamrial@gmail.com
State New
Headers show
Series [FFmpeg-devel] avformat/riffdec: don't unconditionally overwrite WAVEFORMATEXTENSIBLE layout | expand

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 fail Make fate failed

Commit Message

James Almer Sept. 10, 2022, 12:05 p.m. UTC 
Do it only if the value conflicts with the previous channels value.
Fixes ticket #9912

Signed-off-by: James Almer <jamrial@gmail.com>
---
 libavformat/riffdec.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
diff mbox series

Patch

diff --git a/libavformat/riffdec.c b/libavformat/riffdec.c
index 3946ecb72f..aef6b6625a 100644
--- a/libavformat/riffdec.c
+++ b/libavformat/riffdec.c
@@ -102,6 +102,8 @@  int ff_get_wav_header(AVFormatContext *s, AVIOContext *pb,
         return AVERROR_INVALIDDATA;
     }
 
+    av_channel_layout_uninit(&par->ch_layout);
+
     par->codec_type  = AVMEDIA_TYPE_AUDIO;
     if (!big_endian) {
         id                 = avio_rl16(pb);
@@ -189,9 +191,13 @@  int ff_get_wav_header(AVFormatContext *s, AVIOContext *pb,
     if (par->codec_id == AV_CODEC_ID_ADPCM_G726 && par->sample_rate)
         par->bits_per_coded_sample = par->bit_rate / par->sample_rate;
 
-    av_channel_layout_uninit(&par->ch_layout);
-    par->ch_layout.order       = AV_CHANNEL_ORDER_UNSPEC;
-    par->ch_layout.nb_channels = channels;
+    /* ignore WAVEFORMATEXTENSIBLE layout if different from channel count */
+    if (par->ch_layout.order == AV_CHANNEL_ORDER_NATIVE &&
+        channels != par->ch_layout.nb_channels) {
+        av_channel_layout_uninit(&par->ch_layout);
+        par->ch_layout.order       = AV_CHANNEL_ORDER_UNSPEC;
+        par->ch_layout.nb_channels = channels;
+    }
 
     return 0;
 }