diff mbox series

[FFmpeg-devel] MAINTAINERS: add maintainer for the imf demuxer

Message ID 20220915224628.8059-1-pal@sandflow.com
State Accepted
Commit b8f9cc5e8e6a6832763172b517ab9cdc0594d533
Headers show
Series [FFmpeg-devel] MAINTAINERS: add maintainer for the imf demuxer | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Pierre-Anthony Lemieux Sept. 15, 2022, 10:46 p.m. UTC 
From: Pierre-Anthony Lemieux <pal@palemieux.com>

---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

Comments

Lynne Sept. 15, 2022, 11:07 p.m. UTC | #1 
Sep 16, 2022, 00:46 by pal@sandflow.com:

> From: Pierre-Anthony Lemieux <pal@palemieux.com>
>
> ---
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ed2ec0b90c..2d37f0b86a 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -436,6 +436,7 @@ Muxers/Demuxers:
>  idcin.c                               Mike Melanson
>  idroqdec.c                            Mike Melanson
>  iff.c                                 Jaikrishnan Menon
> +  imf*                                  Pierre-Anthony Lemieux
>  img2*.c                               Michael Niedermayer
>  ipmovie.c                             Mike Melanson
>  ircam*                                Paul B Mahol
> @@ -633,6 +634,7 @@ Nikolay Aleksandrov           8978 1D8C FB71 588E 4B27 EAA8 C4F0 B5FC E011 13B1
>  Panagiotis Issaris            6571 13A3 33D9 3726 F728 AA98 F643 B12E ECF3 E029
>  Peter Ross                    A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B
>  Philip Langdale               5DC5 8D66 5FBA 3A43 18EC 045E F8D6 B194 6A75 682E
> +Pierre-Anthony Lemieux (pal)  F4B3 9492 E6F2 E4AF AEC8 46CB 698F A1F0 F8D4 EED4
>  Ramiro Polla                  7859 C65B 751B 1179 792E DAE8 8E95 8B2F 9B6C 5700
>  Reimar Doeffinger             C61D 16E5 9E2C D10C 8958 38A4 0899 A2B9 06D4 D9C7
>  Reinhard Tartler              9300 5DC2 7E87 6C37 ED7B CA9A 9808 3544 9453 48A4
>

That list is for those with push access. Are you sure you want that?
We don't have strict requirements for that, but you're just past
the #commits to get a vote on TC questions.
Reviewing patches takes a while, but that's just how it is when
they're of little interest to most.
Pierre-Anthony Lemieux Sept. 16, 2022, 12:03 a.m. UTC | #2 
On Thu, Sep 15, 2022 at 4:07 PM Lynne <dev@lynne.ee> wrote:
>
> Sep 16, 2022, 00:46 by pal@sandflow.com:
>
> > From: Pierre-Anthony Lemieux <pal@palemieux.com>
> >
> > ---
> >  MAINTAINERS | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index ed2ec0b90c..2d37f0b86a 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -436,6 +436,7 @@ Muxers/Demuxers:
> >  idcin.c                               Mike Melanson
> >  idroqdec.c                            Mike Melanson
> >  iff.c                                 Jaikrishnan Menon
> > +  imf*                                  Pierre-Anthony Lemieux
> >  img2*.c                               Michael Niedermayer
> >  ipmovie.c                             Mike Melanson
> >  ircam*                                Paul B Mahol
> > @@ -633,6 +634,7 @@ Nikolay Aleksandrov           8978 1D8C FB71 588E 4B27 EAA8 C4F0 B5FC E011 13B1
> >  Panagiotis Issaris            6571 13A3 33D9 3726 F728 AA98 F643 B12E ECF3 E029
> >  Peter Ross                    A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B
> >  Philip Langdale               5DC5 8D66 5FBA 3A43 18EC 045E F8D6 B194 6A75 682E
> > +Pierre-Anthony Lemieux (pal)  F4B3 9492 E6F2 E4AF AEC8 46CB 698F A1F0 F8D4 EED4
> >  Ramiro Polla                  7859 C65B 751B 1179 792E DAE8 8E95 8B2F 9B6C 5700
> >  Reimar Doeffinger             C61D 16E5 9E2C D10C 8958 38A4 0899 A2B9 06D4 D9C7
> >  Reinhard Tartler              9300 5DC2 7E87 6C37 ED7B CA9A 9808 3544 9453 48A4
> >
>
> That list is for those with push access. Are you sure you want that?

You make it sound unpleasant :)

In all seriousness, my objective is being responsive to issues filed
against the IMF demuxer.

I am happy to set aside the time to be a maintainer if it helps
achieve that objective.

I am also happy to not be a maintainer if it will not help.

> We don't have strict requirements for that, but you're just past
> the #commits to get a vote on TC questions.
> Reviewing patches takes a while, but that's just how it is when
> they're of little interest to most.

Yes.

Isn't this particularly true when there is no maintainer for that
module -- as is currently the case for the IMF demuxer?

On a related note, I would think that review of narrow bug fixes like
[1] would require relatively less time than, say, the addition of an
imf muxer.

[1] https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=7416

In any case thanks for your help/input since the beginning of my
involvement with the codebase.

> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Paul B Mahol Sept. 16, 2022, 6:37 a.m. UTC | #3 
On 9/16/22, Pierre-Anthony Lemieux <pal@sandflow.com> wrote:
> On Thu, Sep 15, 2022 at 4:07 PM Lynne <dev@lynne.ee> wrote:
>>
>> Sep 16, 2022, 00:46 by pal@sandflow.com:
>>
>> > From: Pierre-Anthony Lemieux <pal@palemieux.com>
>> >
>> > ---
>> >  MAINTAINERS | 2 ++
>> >  1 file changed, 2 insertions(+)
>> >
>> > diff --git a/MAINTAINERS b/MAINTAINERS
>> > index ed2ec0b90c..2d37f0b86a 100644
>> > --- a/MAINTAINERS
>> > +++ b/MAINTAINERS
>> > @@ -436,6 +436,7 @@ Muxers/Demuxers:
>> >  idcin.c                               Mike Melanson
>> >  idroqdec.c                            Mike Melanson
>> >  iff.c                                 Jaikrishnan Menon
>> > +  imf*                                  Pierre-Anthony Lemieux
>> >  img2*.c                               Michael Niedermayer
>> >  ipmovie.c                             Mike Melanson
>> >  ircam*                                Paul B Mahol
>> > @@ -633,6 +634,7 @@ Nikolay Aleksandrov           8978 1D8C FB71 588E
>> > 4B27 EAA8 C4F0 B5FC E011 13B1
>> >  Panagiotis Issaris            6571 13A3 33D9 3726 F728 AA98 F643 B12E
>> > ECF3 E029
>> >  Peter Ross                    A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5
>> > AC40 DD6B
>> >  Philip Langdale               5DC5 8D66 5FBA 3A43 18EC 045E F8D6 B194
>> > 6A75 682E
>> > +Pierre-Anthony Lemieux (pal)  F4B3 9492 E6F2 E4AF AEC8 46CB 698F A1F0
>> > F8D4 EED4
>> >  Ramiro Polla                  7859 C65B 751B 1179 792E DAE8 8E95 8B2F
>> > 9B6C 5700
>> >  Reimar Doeffinger             C61D 16E5 9E2C D10C 8958 38A4 0899 A2B9
>> > 06D4 D9C7
>> >  Reinhard Tartler              9300 5DC2 7E87 6C37 ED7B CA9A 9808 3544
>> > 9453 48A4
>> >
>>
>> That list is for those with push access. Are you sure you want that?
>
> You make it sound unpleasant :)
>
> In all seriousness, my objective is being responsive to issues filed
> against the IMF demuxer.
>
> I am happy to set aside the time to be a maintainer if it helps
> achieve that objective.
>
> I am also happy to not be a maintainer if it will not help.
>
>> We don't have strict requirements for that, but you're just past
>> the #commits to get a vote on TC questions.
>> Reviewing patches takes a while, but that's just how it is when
>> they're of little interest to most.
>
> Yes.
>
> Isn't this particularly true when there is no maintainer for that
> module -- as is currently the case for the IMF demuxer?
>
> On a related note, I would think that review of narrow bug fixes like
> [1] would require relatively less time than, say, the addition of an
> imf muxer.
>
> [1] https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=7416
>
> In any case thanks for your help/input since the beginning of my
> involvement with the codebase.

Just ask someone to push patches more frequently on ML and on IRC.

>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
Michael Niedermayer Sept. 16, 2022, 11:05 a.m. UTC | #4 
On Thu, Sep 15, 2022 at 03:46:28PM -0700, pal@sandflow.com wrote:
> From: Pierre-Anthony Lemieux <pal@palemieux.com>
> 
> ---
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ed2ec0b90c..2d37f0b86a 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -436,6 +436,7 @@ Muxers/Demuxers:
>    idcin.c                               Mike Melanson
>    idroqdec.c                            Mike Melanson
>    iff.c                                 Jaikrishnan Menon
> +  imf*                                  Pierre-Anthony Lemieux
>    img2*.c                               Michael Niedermayer
>    ipmovie.c                             Mike Melanson
>    ircam*                                Paul B Mahol
> @@ -633,6 +634,7 @@ Nikolay Aleksandrov           8978 1D8C FB71 588E 4B27 EAA8 C4F0 B5FC E011 13B1
>  Panagiotis Issaris            6571 13A3 33D9 3726 F728 AA98 F643 B12E ECF3 E029
>  Peter Ross                    A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B
>  Philip Langdale               5DC5 8D66 5FBA 3A43 18EC 045E F8D6 B194 6A75 682E
> +Pierre-Anthony Lemieux (pal)  F4B3 9492 E6F2 E4AF AEC8 46CB 698F A1F0 F8D4 EED4
>  Ramiro Polla                  7859 C65B 751B 1179 792E DAE8 8E95 8B2F 9B6C 5700
>  Reimar Doeffinger             C61D 16E5 9E2C D10C 8958 38A4 0899 A2B9 06D4 D9C7
>  Reinhard Tartler              9300 5DC2 7E87 6C37 ED7B CA9A 9808 3544 9453 48A4
> -- 
> 2.25.1

LGTM

thx

[...]
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index ed2ec0b90c..2d37f0b86a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -436,6 +436,7 @@  Muxers/Demuxers:
   idcin.c                               Mike Melanson
   idroqdec.c                            Mike Melanson
   iff.c                                 Jaikrishnan Menon
+  imf*                                  Pierre-Anthony Lemieux
   img2*.c                               Michael Niedermayer
   ipmovie.c                             Mike Melanson
   ircam*                                Paul B Mahol
@@ -633,6 +634,7 @@  Nikolay Aleksandrov           8978 1D8C FB71 588E 4B27 EAA8 C4F0 B5FC E011 13B1
 Panagiotis Issaris            6571 13A3 33D9 3726 F728 AA98 F643 B12E ECF3 E029
 Peter Ross                    A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B
 Philip Langdale               5DC5 8D66 5FBA 3A43 18EC 045E F8D6 B194 6A75 682E
+Pierre-Anthony Lemieux (pal)  F4B3 9492 E6F2 E4AF AEC8 46CB 698F A1F0 F8D4 EED4
 Ramiro Polla                  7859 C65B 751B 1179 792E DAE8 8E95 8B2F 9B6C 5700
 Reimar Doeffinger             C61D 16E5 9E2C D10C 8958 38A4 0899 A2B9 06D4 D9C7
 Reinhard Tartler              9300 5DC2 7E87 6C37 ED7B CA9A 9808 3544 9453 48A4