| Message ID | 20221019085351.59862-1-martin@martin.st |
|---|---|
| State | Accepted |
| Commit | 2eb601e86552e215305ad68679a9a4c35de21a9d |
| Headers | show |
| Series | [FFmpeg-devel] configure: Remove a leftover comment about MSVC C99 support | expand |
| Context | Check | Description |
|---|---|---|
| yinshiyou/make_loongarch64 | success | Make finished |
| yinshiyou/make_fate_loongarch64 | success | Make fate finished |
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
On Wed, 19 Oct 2022, Martin Storsjö wrote: > Support for building with older versions of MSVC (with the > c99wrap/c99conv frontend) was removed in > ce943dd6acbfdfc40223c0fb24d4cad438e6499c. > > Signed-off-by: Martin Storsjö <martin@martin.st> > --- > configure | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/configure b/configure > index 6712d045d9..ed52212f93 100755 > --- a/configure > +++ b/configure > @@ -4368,12 +4368,6 @@ case "$toolchain" in > esac > ;; > msvc) > - # Check whether the current MSVC version needs the C99 converter. > - # From MSVC 2013 (compiler major version 18) onwards, it does actually > - # support enough of C99 to build ffmpeg. Default to the new > - # behaviour if the regexp was unable to match anything, since this > - # successfully parses the version number of existing supported > - # versions that require the converter (MSVC 2010 and 2012). > cl_major_ver=$(cl.exe 2>&1 | sed -n 's/.*Version \([[:digit:]]\{1,\}\)\..*/\1/p') > if [ -z "$cl_major_ver" ] || [ $cl_major_ver -ge 18 ]; then > cc_default="cl.exe" > -- > 2.37.0 (Apple Git-136) Will push later today. // Martin
diff --git a/configure b/configure index 6712d045d9..ed52212f93 100755 --- a/configure +++ b/configure @@ -4368,12 +4368,6 @@ case "$toolchain" in esac ;; msvc) - # Check whether the current MSVC version needs the C99 converter. - # From MSVC 2013 (compiler major version 18) onwards, it does actually - # support enough of C99 to build ffmpeg. Default to the new - # behaviour if the regexp was unable to match anything, since this - # successfully parses the version number of existing supported - # versions that require the converter (MSVC 2010 and 2012). cl_major_ver=$(cl.exe 2>&1 | sed -n 's/.*Version \([[:digit:]]\{1,\}\)\..*/\1/p') if [ -z "$cl_major_ver" ] || [ $cl_major_ver -ge 18 ]; then cc_default="cl.exe"
Support for building with older versions of MSVC (with the c99wrap/c99conv frontend) was removed in ce943dd6acbfdfc40223c0fb24d4cad438e6499c. Signed-off-by: Martin Storsjö <martin@martin.st> --- configure | 6 ------ 1 file changed, 6 deletions(-)