| Message ID | 20221021035528.413664-1-ccom@randomderp.com |
|---|---|
| State | New |
| Headers | show |
| Series | [FFmpeg-devel,v2,1/2] avcodec/libsvtav1: remove compressed_ten_bit_format and simplify alloc_buffer | expand |
| Context | Check | Description |
|---|---|---|
| yinshiyou/make_loongarch64 | success | Make finished |
| yinshiyou/make_fate_loongarch64 | success | Make fate finished |
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
On Thu, Oct 20, 2022 at 11:56 PM Christopher Degawa <ccom@randomderp.com> wrote: > From: Christopher Degawa <christopher.degawa@intel.com> > > compressed_ten_bit_format has been deprecated upstream and has no effect > and can be removed. Plus, technically it was never used in the first place > since it would require the app (ffmpeg) to set it and do additional > processing of the input frames. > > Also simplify alloc_buffer by removing calculations relating to the > non-existant processing. > > Signed-off-by: Christopher Degawa <christopher.degawa@intel.com> > --- > Ping on this and the other patch?
On Thu, Oct 27, 2022 at 11:23 AM Christopher Degawa <ccom@randomderp.com> wrote: > > > On Thu, Oct 20, 2022 at 11:56 PM Christopher Degawa <ccom@randomderp.com> > wrote: > >> From: Christopher Degawa <christopher.degawa@intel.com> >> >> compressed_ten_bit_format has been deprecated upstream and has no effect >> and can be removed. Plus, technically it was never used in the first place >> since it would require the app (ffmpeg) to set it and do additional >> processing of the input frames. >> >> Also simplify alloc_buffer by removing calculations relating to the >> non-existant processing. >> >> Signed-off-by: Christopher Degawa <christopher.degawa@intel.com> >> --- >> > > Ping on this and the other patch? > ping again? I don't have push rights or anything and nobody is listed as the maintainer for libsvtav1.c, so I don't really have anyone I can specifically ping for these. >
On 11/17/2022 8:23 PM, Christopher Degawa wrote: > On Thu, Oct 27, 2022 at 11:23 AM Christopher Degawa <ccom@randomderp.com> > wrote: > >> >> >> On Thu, Oct 20, 2022 at 11:56 PM Christopher Degawa <ccom@randomderp.com> >> wrote: >> >>> From: Christopher Degawa <christopher.degawa@intel.com> >>> >>> compressed_ten_bit_format has been deprecated upstream and has no effect >>> and can be removed. Plus, technically it was never used in the first place >>> since it would require the app (ffmpeg) to set it and do additional >>> processing of the input frames. >>> >>> Also simplify alloc_buffer by removing calculations relating to the >>> non-existant processing. >>> >>> Signed-off-by: Christopher Degawa <christopher.degawa@intel.com> >>> --- >>> >> >> Ping on this and the other patch? >> > > ping again? I don't have push rights or anything and nobody is listed as > the maintainer for libsvtav1.c, so I don't really have anyone I can > specifically ping for these. Done. Sorry for the delay.
diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c index 2f5634cee0..28da206cf8 100644 --- a/libavcodec/libsvtav1.c +++ b/libavcodec/libsvtav1.c @@ -124,16 +124,12 @@ static int svt_print_error(void *log_ctx, EbErrorType err, static int alloc_buffer(EbSvtAv1EncConfiguration *config, SvtContext *svt_enc) { - const int pack_mode_10bit = - (config->encoder_bit_depth > 8) && (config->compressed_ten_bit_format == 0) ? 1 : 0; - const size_t luma_size_8bit = - config->source_width * config->source_height * (1 << pack_mode_10bit); - const size_t luma_size_10bit = - (config->encoder_bit_depth > 8 && pack_mode_10bit == 0) ? luma_size_8bit : 0; + const size_t luma_size = config->source_width * config->source_height * + (config->encoder_bit_depth > 8 ? 2 : 1); EbSvtIOFormat *in_data; - svt_enc->raw_size = (luma_size_8bit + luma_size_10bit) * 3 / 2; + svt_enc->raw_size = luma_size * 3 / 2; // allocate buffer for in and out svt_enc->in_buf = av_mallocz(sizeof(*svt_enc->in_buf));