diff mbox series

[FFmpeg-devel,1/2] amfenc: Update the min version to 1.4.28.0 for AMF SDK.

Message ID 20221220152038.1795-1-Dmitriy.Ovchinnikov@amd.com
State Accepted
Commit 23d4f9223a81a4d659ad08cad5014f773d9b8b99
Headers show
Series [FFmpeg-devel,1/2] amfenc: Update the min version to 1.4.28.0 for AMF SDK. | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Dmitrii Ovchinnikov Dec. 20, 2022, 3:20 p.m. UTC
From: Dmitrii Ovchinnikov <ovchinnikov.dmitrii@gmail.com>

---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jean-Baptiste Kempf Dec. 20, 2022, 4:41 p.m. UTC | #1
Hello,

When was this release released?
Is it headers only or is it runtime too?

Best

jb

On Tue, 20 Dec 2022, at 16:20, Dmitrii Ovchinnikov wrote:
> From: Dmitrii Ovchinnikov <ovchinnikov.dmitrii@gmail.com>
>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 2180ebb4f1..8a20d67612 100755
> --- a/configure
> +++ b/configure
> @@ -7034,7 +7034,7 @@ fi
> 
>  enabled amf &&
>      check_cpp_condition amf "AMF/core/Version.h" \
> -        "(AMF_VERSION_MAJOR << 48 | AMF_VERSION_MINOR << 32 | 
> AMF_VERSION_RELEASE << 16 | AMF_VERSION_BUILD_NUM) >= 
> 0x0001000400090000"
> +        "(AMF_VERSION_MAJOR << 48 | AMF_VERSION_MINOR << 32 | 
> AMF_VERSION_RELEASE << 16 | AMF_VERSION_BUILD_NUM) >= 
> 0x00010004001c0000"
> 
>  # Funny iconv installations are not unusual, so check it after all 
> flags have been set
>  if enabled libc_iconv; then
> -- 
> 2.38.1.windows.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Dmitrii Ovchinnikov Dec. 20, 2022, 5:48 p.m. UTC | #2
Hi,

>>When was this release released?
The release was 13.12.2022
>> Is it headers only or is it runtime too?
it still supports old drivers, but to use the av1 encoder, you need an
up-to-date driver version and a supported graphics card.
Jean-Baptiste Kempf Jan. 27, 2023, 3:47 p.m. UTC | #3
Hello,

On Tue, 20 Dec 2022, at 18:48, Dmitrii Ovchinnikov wrote:
> Hi,
>
>>>When was this release released?
> The release was 13.12.2022
>>> Is it headers only or is it runtime too?
> it still supports old drivers, but to use the av1 encoder, you need an
> up-to-date driver version and a supported graphics card.

I've tested this patch and it works.

Can someone apply this, please?

jb
Gyan Doshi Jan. 27, 2023, 3:58 p.m. UTC | #4
On 2023-01-27 09:17 pm, Jean-Baptiste Kempf wrote:
> Hello,
>
> On Tue, 20 Dec 2022, at 18:48, Dmitrii Ovchinnikov wrote:
>> Hi,
>>
>>>> When was this release released?
>> The release was 13.12.2022
>>>> Is it headers only or is it runtime too?
>> it still supports old drivers, but to use the av1 encoder, you need an
>> up-to-date driver version and a supported graphics card.
> I've tested this patch and it works.
>
> Can someone apply this, please?

Only the first one?

Regards,
Gyan
Jean-Baptiste Kempf Jan. 27, 2023, 4 p.m. UTC | #5
On Fri, 27 Jan 2023, at 16:58, Gyan Doshi wrote:
> On 2023-01-27 09:17 pm, Jean-Baptiste Kempf wrote:
>> Hello,
>>
>> On Tue, 20 Dec 2022, at 18:48, Dmitrii Ovchinnikov wrote:
>>> Hi,
>>>
>>>>> When was this release released?
>>> The release was 13.12.2022
>>>>> Is it headers only or is it runtime too?
>>> it still supports old drivers, but to use the av1 encoder, you need an
>>> up-to-date driver version and a supported graphics card.
>> I've tested this patch and it works.
>>
>> Can someone apply this, please?
>
> Only the first one?

I tested both, including the second one (AV1 encoding support) and it works.
Gyan Doshi Jan. 27, 2023, 4:04 p.m. UTC | #6
On 2023-01-27 09:30 pm, Jean-Baptiste Kempf wrote:
> On Fri, 27 Jan 2023, at 16:58, Gyan Doshi wrote:
>> On 2023-01-27 09:17 pm, Jean-Baptiste Kempf wrote:
>>> Hello,
>>>
>>> On Tue, 20 Dec 2022, at 18:48, Dmitrii Ovchinnikov wrote:
>>>> Hi,
>>>>
>>>>>> When was this release released?
>>>> The release was 13.12.2022
>>>>>> Is it headers only or is it runtime too?
>>>> it still supports old drivers, but to use the av1 encoder, you need an
>>>> up-to-date driver version and a supported graphics card.
>>> I've tested this patch and it works.
>>>
>>> Can someone apply this, please?
>> Only the first one?
> I tested both, including the second one (AV1 encoding support) and it works.

Ok, since Dmitrii is the AMF maintainer, will do.

Regards,
Gyan
Gyan Doshi Jan. 27, 2023, 5:11 p.m. UTC | #7
On 2023-01-27 09:34 pm, Gyan Doshi wrote:
>
>
> On 2023-01-27 09:30 pm, Jean-Baptiste Kempf wrote:
>> On Fri, 27 Jan 2023, at 16:58, Gyan Doshi wrote:
>>> On 2023-01-27 09:17 pm, Jean-Baptiste Kempf wrote:
>>>> Hello,
>>>>
>>>> On Tue, 20 Dec 2022, at 18:48, Dmitrii Ovchinnikov wrote:
>>>>> Hi,
>>>>>
>>>>>>> When was this release released?
>>>>> The release was 13.12.2022
>>>>>>> Is it headers only or is it runtime too?
>>>>> it still supports old drivers, but to use the av1 encoder, you 
>>>>> need an
>>>>> up-to-date driver version and a supported graphics card.
>>>> I've tested this patch and it works.
>>>>
>>>> Can someone apply this, please?
>>> Only the first one?
>> I tested both, including the second one (AV1 encoding support) and it 
>> works.
>
> Ok, since Dmitrii is the AMF maintainer, will do.

Pushed as 23d4f9223a81a4d659ad08cad5014f773d9b8b99 and 
5f0a7a9169e4714255e6b91b085a55ffa4ae6d58

Regards,
Gyan
diff mbox series

Patch

diff --git a/configure b/configure
index 2180ebb4f1..8a20d67612 100755
--- a/configure
+++ b/configure
@@ -7034,7 +7034,7 @@  fi
 
 enabled amf &&
     check_cpp_condition amf "AMF/core/Version.h" \
-        "(AMF_VERSION_MAJOR << 48 | AMF_VERSION_MINOR << 32 | AMF_VERSION_RELEASE << 16 | AMF_VERSION_BUILD_NUM) >= 0x0001000400090000"
+        "(AMF_VERSION_MAJOR << 48 | AMF_VERSION_MINOR << 32 | AMF_VERSION_RELEASE << 16 | AMF_VERSION_BUILD_NUM) >= 0x00010004001c0000"
 
 # Funny iconv installations are not unusual, so check it after all flags have been set
 if enabled libc_iconv; then