diff mbox series

[FFmpeg-devel] avfilter/vf_colorspace: fix message for missing/incorrect colorspace

Message ID 20230530102906.2108897-1-sboukortt@google.com
State Accepted
Commit 06e8eedeba3882480b80a9797f6d0d86d72aca12
Headers show
Series [FFmpeg-devel] avfilter/vf_colorspace: fix message for missing/incorrect colorspace | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Sami Boukortt May 30, 2023, 10:29 a.m. UTC 
---
 libavfilter/vf_colorspace.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Ronald S. Bultje May 30, 2023, 1:06 p.m. UTC | #1 
Hi,

On Tue, May 30, 2023 at 6:29 AM Sami Boukortt <
sboukortt-at-google.com@ffmpeg.org> wrote:

> ---
>  libavfilter/vf_colorspace.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/libavfilter/vf_colorspace.c b/libavfilter/vf_colorspace.c
> index 21916b7b7a..852dc11c6c 100644
> --- a/libavfilter/vf_colorspace.c
> +++ b/libavfilter/vf_colorspace.c
> @@ -572,15 +572,15 @@ static int create_filtergraph(AVFilterContext *ctx,
>              if (s->out_csp == AVCOL_SPC_UNSPECIFIED) {
>                  if (s->user_all == CS_UNSPECIFIED) {
>                      av_log(ctx, AV_LOG_ERROR,
> -                           "Please specify output transfer
> characteristics\n");
> +                           "Please specify output colorspace\n");
>                  } else {
>                      av_log(ctx, AV_LOG_ERROR,
>                             "Unsupported output color property %d\n",
> s->user_all);
>                  }
>              } else {
>                  av_log(ctx, AV_LOG_ERROR,
> -                       "Unsupported output transfer characteristics %d
> (%s)\n",
> -                       s->out_csp, av_color_space_name(s->out_csp));
> +                       "Unsupported output colorspace %d (%s)\n",
> s->out_csp,
> +                       av_color_space_name(s->out_csp));
>              }
>              return AVERROR(EINVAL);
>          }
> --
> 2.41.0.rc0.172.g3f132b7071-goog
>

Good catch, thanks. Merged.

Ronald
diff mbox series

Patch

diff --git a/libavfilter/vf_colorspace.c b/libavfilter/vf_colorspace.c
index 21916b7b7a..852dc11c6c 100644
--- a/libavfilter/vf_colorspace.c
+++ b/libavfilter/vf_colorspace.c
@@ -572,15 +572,15 @@  static int create_filtergraph(AVFilterContext *ctx,
             if (s->out_csp == AVCOL_SPC_UNSPECIFIED) {
                 if (s->user_all == CS_UNSPECIFIED) {
                     av_log(ctx, AV_LOG_ERROR,
-                           "Please specify output transfer characteristics\n");
+                           "Please specify output colorspace\n");
                 } else {
                     av_log(ctx, AV_LOG_ERROR,
                            "Unsupported output color property %d\n", s->user_all);
                 }
             } else {
                 av_log(ctx, AV_LOG_ERROR,
-                       "Unsupported output transfer characteristics %d (%s)\n",
-                       s->out_csp, av_color_space_name(s->out_csp));
+                       "Unsupported output colorspace %d (%s)\n", s->out_csp,
+                       av_color_space_name(s->out_csp));
             }
             return AVERROR(EINVAL);
         }