diff mbox series

[FFmpeg-devel,1/3] avcodec/evc_frame_merge: use av_fast_realloc()

Message ID 20230617151848.1378-1-jamrial@gmail.com
State Accepted
Commit 96fc1927330b03a7674f9376f19565609678f48a
Headers show
Series [FFmpeg-devel,1/3] avcodec/evc_frame_merge: use av_fast_realloc() | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

James Almer June 17, 2023, 3:18 p.m. UTC 
Signed-off-by: James Almer <jamrial@gmail.com>
---
 libavcodec/evc_frame_merge_bsf.c | 24 ++++++++----------------
 1 file changed, 8 insertions(+), 16 deletions(-)

Comments

James Almer June 19, 2023, 6:28 p.m. UTC | #1 
On 6/17/2023 12:18 PM, James Almer wrote:
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>   libavcodec/evc_frame_merge_bsf.c | 24 ++++++++----------------
>   1 file changed, 8 insertions(+), 16 deletions(-)

Will apply the first ten patches.
diff mbox series

Patch

diff --git a/libavcodec/evc_frame_merge_bsf.c b/libavcodec/evc_frame_merge_bsf.c
index 7cc701f5c5..827f114f0b 100644
--- a/libavcodec/evc_frame_merge_bsf.c
+++ b/libavcodec/evc_frame_merge_bsf.c
@@ -26,13 +26,11 @@ 
 #include "evc.h"
 #include "evc_parse.h"
 
-#define INIT_AU_BUF_CAPACITY 1024
-
 // Access unit data
 typedef struct AccessUnitBuffer {
     uint8_t *data;      // the data buffer
     size_t data_size;   // size of data in bytes
-    size_t capacity;    // buffer capacity
+    unsigned capacity;  // buffer capacity
 } AccessUnitBuffer;
 
 typedef struct EVCFMergeContext {
@@ -72,9 +70,8 @@  static int evc_frame_merge_filter(AVBSFContext *bsf, AVPacket *out)
 
     AVPacket *in = ctx->in;
 
-    int free_space = 0;
     size_t  nalu_size = 0;
-    uint8_t *nalu = NULL;
+    uint8_t *buffer, *nalu = NULL;
     int au_end_found = 0;
     int err;
 
@@ -102,15 +99,14 @@  static int evc_frame_merge_filter(AVBSFContext *bsf, AVPacket *out)
 
     au_end_found = end_of_access_unit_found(parser_ctx);
 
-    free_space = ctx->au_buffer.capacity - ctx->au_buffer.data_size;
-    while (free_space < in->size) {
-        ctx->au_buffer.capacity *= 2;
-        free_space = ctx->au_buffer.capacity - ctx->au_buffer.data_size;
-
-        if (free_space >= in->size)
-            ctx->au_buffer.data = av_realloc(ctx->au_buffer.data, ctx->au_buffer.capacity);
+    buffer = av_fast_realloc(ctx->au_buffer.data, &ctx->au_buffer.capacity,
+                             ctx->au_buffer.data_size + in->size);
+    if (!buffer) {
+        av_freep(&ctx->au_buffer.data);
+        return AVERROR(ENOMEM);
     }
 
+    ctx->au_buffer.data = buffer;
     memcpy(ctx->au_buffer.data + ctx->au_buffer.data_size, in->data, in->size);
 
     ctx->au_buffer.data_size += in->size;
@@ -143,10 +139,6 @@  static int evc_frame_merge_init(AVBSFContext *bsf)
     if (!ctx->in)
         return AVERROR(ENOMEM);
 
-    ctx->au_buffer.capacity = INIT_AU_BUF_CAPACITY;
-    ctx->au_buffer.data = av_malloc(INIT_AU_BUF_CAPACITY);
-    ctx->au_buffer.data_size = 0;
-
     return 0;
 }