diff mbox series

[FFmpeg-devel,06/22] lavfi: make sure frame SAR matches the link value

Message ID 20230707094847.25324-6-anton@khirnov.net
State Accepted
Commit fcc33ada47e594d6b35b71c4a998af796f56492e
Headers show
Series [FFmpeg-devel,01/22] lavc/encode: print separate messages for unknown and unsupported formats | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Anton Khirnov July 7, 2023, 9:48 a.m. UTC 
---
 libavfilter/avfilter.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Michael Niedermayer July 15, 2023, 9:10 p.m. UTC | #1 
On Fri, Jul 07, 2023 at 11:48:31AM +0200, Anton Khirnov wrote:
> ---
>  libavfilter/avfilter.c | 2 ++
>  1 file changed, 2 insertions(+)

Breaks aspect ratio of this, and likely others

./ffmpeg -i ~/tickets/4161/VR_MOVIE_GuyMartinsSpitfireBcast169\ qsf\ lappyAspectNoChnge_extract.mpg -bitexact -vcodec libx264 -an -vsync cfr -y file-169.ts
./ffplay file-169.ts

the ffplay displays the wrong aspect and it also shows the video with the wrong aspect
after this change

ffmpeg-bugs/trac/ticket4161/VR_MOVIE_GuyMartinsSpitfireBcast169 qsf lappyAspectNoChnge_extract.mpg

thx
[...]
diff mbox series

Patch

diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c
index 0141b64cbc..04887b6ee5 100644
--- a/libavfilter/avfilter.c
+++ b/libavfilter/avfilter.c
@@ -984,6 +984,8 @@  int ff_filter_frame(AVFilterLink *link, AVFrame *frame)
             av_assert1(frame->width               == link->w);
             av_assert1(frame->height               == link->h);
         }
+
+        frame->sample_aspect_ratio = link->sample_aspect_ratio;
     } else {
         if (frame->format != link->format) {
             av_log(link->dst, AV_LOG_ERROR, "Format change is not supported\n");