diff mbox series

[FFmpeg-devel,v2,2/3] tests/fate/flvenc: add vp9 in enhanced flv test case

Message ID 20230718112159.40655-3-lq@chinaffmpeg.org
State New
Headers show
Series Add test cases of hevc, vp9, av1 in enhanced flv | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Liu Steven July 18, 2023, 11:21 a.m. UTC
Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
---
 tests/fate/flvenc.mak           | 10 ++++++++++
 tests/ref/fate/enhanced-flv-vp9 |  6 ++++++
 2 files changed, 16 insertions(+)
 create mode 100644 tests/ref/fate/enhanced-flv-vp9

Comments

Michael Niedermayer July 18, 2023, 3:46 p.m. UTC | #1
On Tue, Jul 18, 2023 at 07:21:57PM +0800, Steven Liu wrote:
> Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
> ---
>  tests/fate/flvenc.mak           | 10 ++++++++++
>  tests/ref/fate/enhanced-flv-vp9 |  6 ++++++
>  2 files changed, 16 insertions(+)
>  create mode 100644 tests/ref/fate/enhanced-flv-vp9
> 
> diff --git a/tests/fate/flvenc.mak b/tests/fate/flvenc.mak
> index 69210c78a2..dafad26734 100644
> --- a/tests/fate/flvenc.mak
> +++ b/tests/fate/flvenc.mak
> @@ -12,5 +12,15 @@ fate-enhanced-flv-hevc: tests/data/enhanced_flv_hevc.flv
>  fate-enhanced-flv-hevc: SRC = $(TARGET_PATH)/tests/data/enhanced_flv_hevc.flv
>  fate-enhanced-flv-hevc: CMD = framecrc -auto_conversion_filters -flags +bitexact -i $(TARGET_PATH)/tests/data/enhanced_flv_hevc.flv
>  
> +tests/data/enhanced_flv_vp9.flv: TAG = GEN
> +tests/data/enhanced_flv_vp9.flv: ffmpeg$(PROGSSUF)$(EXESUF) | tests/data
> +	$(M)$(TARGET_EXEC) $(TARGET_PATH)/$< -nostdin \
> +		-f lavfi -i "testsrc=s=176x144:r=1:n=1:d=0.04" -pix_fmt yuv420p -c:v libvpx-vp9 -frames 1 -y $(TARGET_PATH)/tests/data/enhanced_flv_vp9.flv 2>/dev/null

generating data with an extarnal lib (like libvpx) will not produce the same
results accross revissions of that lib


> +
> +FATE_FLVENC_FFMPEG_FFPROBE-$(call TRANSCODE, LIBVPX_VP9 VP9, FLV, TESTSRC_FILTER LAVFI_INDEV) += fate-enhanced-flv-vp9
> +fate-enhanced-flv-vp9: tests/data/enhanced_flv_vp9.flv
> +fate-enhanced-flv-vp9: SRC = $(TARGET_PATH)/tests/data/enhanced_flv_vp9.flv
> +fate-enhanced-flv-vp9: CMD = framecrc -auto_conversion_filters -flags +bitexact -i $(TARGET_PATH)/tests/data/enhanced_flv_vp9.flv




> +
>  FATE_FFMPEG_FFPROBE += $(FATE_FLVENC_FFMPEG_FFPROBE-yes)
>  fate-flvenc: $(FATE_FLVENC_FFMPEG_FFPROBE-yes)
> diff --git a/tests/ref/fate/enhanced-flv-vp9 b/tests/ref/fate/enhanced-flv-vp9
> new file mode 100644
> index 0000000000..1669943bde
> --- /dev/null
> +++ b/tests/ref/fate/enhanced-flv-vp9
> @@ -0,0 +1,6 @@
> +#tb 0: 1/1
> +#media_type 0: video
> +#codec_id 0: rawvideo
> +#dimensions 0: 176x144
> +#sar 0: 0/1
> +0,          0,          0,        1,    38016, 0xec80eb63

Thats what i would get here:

--- ./tests/ref/fate/enhanced-flv-vp9	2023-07-18 17:43:03.926825292 +0200
+++ tests/data/fate/enhanced-flv-vp9	2023-07-18 17:43:08.402875138 +0200
@@ -3,4 +3,4 @@
 #codec_id 0: rawvideo
 #dimensions 0: 176x144
 #sar 0: 0/1
-0,          0,          0,        1,    38016, 0xec80eb63
+0,          0,          0,        1,    38016, 0x8b3ceb6b



[...]
Steven Liu July 19, 2023, 9:10 a.m. UTC | #2
Michael Niedermayer <michael@niedermayer.cc> 于2023年7月18日周二 23:46写道:
>
> On Tue, Jul 18, 2023 at 07:21:57PM +0800, Steven Liu wrote:
> > Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
> > ---
> >  tests/fate/flvenc.mak           | 10 ++++++++++
> >  tests/ref/fate/enhanced-flv-vp9 |  6 ++++++
> >  2 files changed, 16 insertions(+)
> >  create mode 100644 tests/ref/fate/enhanced-flv-vp9
> >
> > diff --git a/tests/fate/flvenc.mak b/tests/fate/flvenc.mak
> > index 69210c78a2..dafad26734 100644
> > --- a/tests/fate/flvenc.mak
> > +++ b/tests/fate/flvenc.mak
> > @@ -12,5 +12,15 @@ fate-enhanced-flv-hevc: tests/data/enhanced_flv_hevc.flv
> >  fate-enhanced-flv-hevc: SRC = $(TARGET_PATH)/tests/data/enhanced_flv_hevc.flv
> >  fate-enhanced-flv-hevc: CMD = framecrc -auto_conversion_filters -flags +bitexact -i $(TARGET_PATH)/tests/data/enhanced_flv_hevc.flv
> >
> > +tests/data/enhanced_flv_vp9.flv: TAG = GEN
> > +tests/data/enhanced_flv_vp9.flv: ffmpeg$(PROGSSUF)$(EXESUF) | tests/data
> > +     $(M)$(TARGET_EXEC) $(TARGET_PATH)/$< -nostdin \
> > +             -f lavfi -i "testsrc=s=176x144:r=1:n=1:d=0.04" -pix_fmt yuv420p -c:v libvpx-vp9 -frames 1 -y $(TARGET_PATH)/tests/data/enhanced_flv_vp9.flv 2>/dev/null
>
> generating data with an extarnal lib (like libvpx) will not produce the same
> results accross revissions of that lib
Hi Michael,

Yes, i resubmit new patchset modified as Nicolas suggestion which try
to use the samples from fate-suite.
new patchset is: https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=9350

Thanks

Steven
diff mbox series

Patch

diff --git a/tests/fate/flvenc.mak b/tests/fate/flvenc.mak
index 69210c78a2..dafad26734 100644
--- a/tests/fate/flvenc.mak
+++ b/tests/fate/flvenc.mak
@@ -12,5 +12,15 @@  fate-enhanced-flv-hevc: tests/data/enhanced_flv_hevc.flv
 fate-enhanced-flv-hevc: SRC = $(TARGET_PATH)/tests/data/enhanced_flv_hevc.flv
 fate-enhanced-flv-hevc: CMD = framecrc -auto_conversion_filters -flags +bitexact -i $(TARGET_PATH)/tests/data/enhanced_flv_hevc.flv
 
+tests/data/enhanced_flv_vp9.flv: TAG = GEN
+tests/data/enhanced_flv_vp9.flv: ffmpeg$(PROGSSUF)$(EXESUF) | tests/data
+	$(M)$(TARGET_EXEC) $(TARGET_PATH)/$< -nostdin \
+		-f lavfi -i "testsrc=s=176x144:r=1:n=1:d=0.04" -pix_fmt yuv420p -c:v libvpx-vp9 -frames 1 -y $(TARGET_PATH)/tests/data/enhanced_flv_vp9.flv 2>/dev/null
+
+FATE_FLVENC_FFMPEG_FFPROBE-$(call TRANSCODE, LIBVPX_VP9 VP9, FLV, TESTSRC_FILTER LAVFI_INDEV) += fate-enhanced-flv-vp9
+fate-enhanced-flv-vp9: tests/data/enhanced_flv_vp9.flv
+fate-enhanced-flv-vp9: SRC = $(TARGET_PATH)/tests/data/enhanced_flv_vp9.flv
+fate-enhanced-flv-vp9: CMD = framecrc -auto_conversion_filters -flags +bitexact -i $(TARGET_PATH)/tests/data/enhanced_flv_vp9.flv
+
 FATE_FFMPEG_FFPROBE += $(FATE_FLVENC_FFMPEG_FFPROBE-yes)
 fate-flvenc: $(FATE_FLVENC_FFMPEG_FFPROBE-yes)
diff --git a/tests/ref/fate/enhanced-flv-vp9 b/tests/ref/fate/enhanced-flv-vp9
new file mode 100644
index 0000000000..1669943bde
--- /dev/null
+++ b/tests/ref/fate/enhanced-flv-vp9
@@ -0,0 +1,6 @@ 
+#tb 0: 1/1
+#media_type 0: video
+#codec_id 0: rawvideo
+#dimensions 0: 176x144
+#sar 0: 0/1
+0,          0,          0,        1,    38016, 0xec80eb63