diff mbox series

[FFmpeg-devel] avformat/flv: correct the video frametype mask to 0x70

Message ID 20230726082711.92361-1-lq@chinaffmpeg.org
State Accepted
Commit a9a92682dd72b2593b79b099f96042c73f8694d2
Headers show
Series [FFmpeg-devel] avformat/flv: correct the video frametype mask to 0x70 | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Liu Steven July 26, 2023, 8:27 a.m. UTC
avformat/flv: correct the video frametype mask to 0x70

because the flv specification said the video frametype
should use value range from 0x00 to 0x70,
so use 0xF0 have no problem before support enhanced flv,
but the 0xF0 will get incorrect result after support enhanced flv,
so should set the video frametype mask 0x70 to make it correct now.

Reported-By: flvAnalyser <hybase@qq.com>
Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
---
 libavformat/flv.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Steven Liu Aug. 14, 2023, 6:18 a.m. UTC | #1
Steven Liu <lq@chinaffmpeg.org> 于2023年7月26日周三 16:27写道:
>
> avformat/flv: correct the video frametype mask to 0x70
>
> because the flv specification said the video frametype
> should use value range from 0x00 to 0x70,
> so use 0xF0 have no problem before support enhanced flv,
> but the 0xF0 will get incorrect result after support enhanced flv,
> so should set the video frametype mask 0x70 to make it correct now.
>
> Reported-By: flvAnalyser <hybase@qq.com>
> Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
> ---
>  libavformat/flv.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/flv.h b/libavformat/flv.h
> index 91e0a4140c..f710963b92 100644
> --- a/libavformat/flv.h
> +++ b/libavformat/flv.h
> @@ -48,7 +48,7 @@
>  #define FLV_AUDIO_CODECID_MASK    0xf0
>
>  #define FLV_VIDEO_CODECID_MASK    0x0f
> -#define FLV_VIDEO_FRAMETYPE_MASK  0xf0
> +#define FLV_VIDEO_FRAMETYPE_MASK  0x70
>
>  #define AMF_END_OF_OBJECT         0x09
>
> --
> 2.40.0
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

pushed


Thanks
Steven
diff mbox series

Patch

diff --git a/libavformat/flv.h b/libavformat/flv.h
index 91e0a4140c..f710963b92 100644
--- a/libavformat/flv.h
+++ b/libavformat/flv.h
@@ -48,7 +48,7 @@ 
 #define FLV_AUDIO_CODECID_MASK    0xf0
 
 #define FLV_VIDEO_CODECID_MASK    0x0f
-#define FLV_VIDEO_FRAMETYPE_MASK  0xf0
+#define FLV_VIDEO_FRAMETYPE_MASK  0x70
 
 #define AMF_END_OF_OBJECT         0x09