| Message ID | 20230805175148.27422-1-michael@niedermayer.cc |
|---|---|
| State | Accepted |
| Commit | 283bf5c35bc5ac92e061f27c3a680318175a1600 |
| Headers | show |
| Series | [FFmpeg-devel] avcodec/tta: fix signed overflow in decorrelate | expand |
| Context | Check | Description |
|---|---|---|
| yinshiyou/make_loongarch64 | success | Make finished |
| yinshiyou/make_fate_loongarch64 | success | Make fate finished |
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
On Sat, Aug 05, 2023 at 07:51:48PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 2079654542 - -139267653 cannot be represented in type 'int' > Fixes: 60811/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TTA_fuzzer-5915858409750528 > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> > --- > libavcodec/tta.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) will apply [...]
diff --git a/libavcodec/tta.c b/libavcodec/tta.c index 3e89571f16..072e86729d 100644 --- a/libavcodec/tta.c +++ b/libavcodec/tta.c @@ -342,7 +342,7 @@ static int tta_decode_frame(AVCodecContext *avctx, AVFrame *frame, if (s->channels > 1) { int32_t *r = p - 1; for (*p += *r / 2; r > (int32_t*)p - s->channels; r--) - *r = *(r + 1) - *r; + *r = *(r + 1) - (unsigned)*r; } cur_chan = 0; i++;
Fixes: signed integer overflow: 2079654542 - -139267653 cannot be represented in type 'int' Fixes: 60811/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TTA_fuzzer-5915858409750528 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> --- libavcodec/tta.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)