diff mbox series

[FFmpeg-devel] lavu/hwcontext_vaapi: Add vaapi_drm_format_map support for x2rgb10

Message ID 20230809120244.145462-5-nowrep@gmail.com
State New
Headers show
Series [FFmpeg-devel] lavu/hwcontext_vaapi: Add vaapi_drm_format_map support for x2rgb10 | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

David Rosca Aug. 9, 2023, 12:02 p.m. UTC 
Support for allocating frames with x2rgb10 format was added
in c00264f5013, this adds support for importing DMA-BUFs.
---
 libavutil/hwcontext_vaapi.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Rémi Denis-Courmont Aug. 9, 2023, 12:35 p.m. UTC | #1 
Le 9 août 2023 15:02:45 GMT+03:00, David Rosca <nowrep@gmail.com> a écrit :
>Support for allocating frames with x2rgb10 format was added
>in c00264f5013, this adds support for importing DMA-BUFs.
>---
> libavutil/hwcontext_vaapi.c | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/libavutil/hwcontext_vaapi.c b/libavutil/hwcontext_vaapi.c
>index 6c3a227ddd..63544ce476 100644
>--- a/libavutil/hwcontext_vaapi.c
>+++ b/libavutil/hwcontext_vaapi.c
>@@ -1048,6 +1048,9 @@ static const struct {
> #if defined(VA_FOURCC_Y412) && defined(DRM_FORMAT_XVYU12_16161616)
>     DRM_MAP(Y412, 1, DRM_FORMAT_XVYU12_16161616),
> #endif
>+#ifdef defined(VA_FOURCC_X2R10G10B10) && defined(DRM_FORMAT_XRGB2101010)
>+    DRM_MAP(X2R10G10B10, 1, DRM_FORMAT_XRGB2101010),
>+#endif

That syntax is ostensibly wrong. Did you test the patch?

> };
> #undef DRM_MAP
>
David Rosca Aug. 9, 2023, 12:48 p.m. UTC | #2 
On Wed, Aug 9, 2023 at 2:35 PM Rémi Denis-Courmont <remi@remlab.net> wrote:
>
>
>
> Le 9 août 2023 15:02:45 GMT+03:00, David Rosca <nowrep@gmail.com> a écrit :
> >Support for allocating frames with x2rgb10 format was added
> >in c00264f5013, this adds support for importing DMA-BUFs.
> >---
> > libavutil/hwcontext_vaapi.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> >diff --git a/libavutil/hwcontext_vaapi.c b/libavutil/hwcontext_vaapi.c
> >index 6c3a227ddd..63544ce476 100644
> >--- a/libavutil/hwcontext_vaapi.c
> >+++ b/libavutil/hwcontext_vaapi.c
> >@@ -1048,6 +1048,9 @@ static const struct {
> > #if defined(VA_FOURCC_Y412) && defined(DRM_FORMAT_XVYU12_16161616)
> >     DRM_MAP(Y412, 1, DRM_FORMAT_XVYU12_16161616),
> > #endif
> >+#ifdef defined(VA_FOURCC_X2R10G10B10) && defined(DRM_FORMAT_XRGB2101010)
> >+    DRM_MAP(X2R10G10B10, 1, DRM_FORMAT_XRGB2101010),
> >+#endif
>
> That syntax is ostensibly wrong. Did you test the patch?

Sorry, I missed that when it was just

#ifdef VA_FOURCC_X2R10G10B10

copied from the other place.
Fixed in v2.

>
> > };
> > #undef DRM_MAP
> >
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
diff mbox series

Patch

diff --git a/libavutil/hwcontext_vaapi.c b/libavutil/hwcontext_vaapi.c
index 6c3a227ddd..63544ce476 100644
--- a/libavutil/hwcontext_vaapi.c
+++ b/libavutil/hwcontext_vaapi.c
@@ -1048,6 +1048,9 @@  static const struct {
 #if defined(VA_FOURCC_Y412) && defined(DRM_FORMAT_XVYU12_16161616)
     DRM_MAP(Y412, 1, DRM_FORMAT_XVYU12_16161616),
 #endif
+#ifdef defined(VA_FOURCC_X2R10G10B10) && defined(DRM_FORMAT_XRGB2101010)
+    DRM_MAP(X2R10G10B10, 1, DRM_FORMAT_XRGB2101010),
+#endif
 };
 #undef DRM_MAP