diff mbox series

[FFmpeg-devel,3/3] avcodec/vulkan_decode: print also codec header name

Message ID 20230823200600.1480-3-kasper93@gmail.com
State Accepted
Commit 9f66286f0bdd42fe388a7366909c11954fd330a6
Headers show
Series [FFmpeg-devel,1/3] avcodec/vulkan_decode: fix struct type for h265_profile | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Kacper Michajłow Aug. 23, 2023, 8:06 p.m. UTC
Signed-off-by: Kacper Michajłow <kasper93@gmail.com>
---
 libavcodec/vulkan_decode.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Lynne Aug. 25, 2023, 3:02 a.m. UTC | #1
Aug 23, 2023, 22:06 by kasper93@gmail.com:

> Signed-off-by: Kacper Michajłow <kasper93@gmail.com>
> ---
>  libavcodec/vulkan_decode.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/libavcodec/vulkan_decode.c b/libavcodec/vulkan_decode.c
> index 7607edf52e..0d561b7450 100644
> --- a/libavcodec/vulkan_decode.c
> +++ b/libavcodec/vulkan_decode.c
> @@ -863,6 +863,9 @@ static int vulkan_decode_get_profile(AVCodecContext *avctx, AVBufferRef *frames_
>  caps->maxDpbSlots);
>  av_log(avctx, AV_LOG_VERBOSE, "    Maximum active references: %u\n",
>  caps->maxActiveReferencePictures);
> +    av_log(avctx, AV_LOG_VERBOSE, "    Codec header name: '%s' (driver), '%s' (compiled)\n",
> +           caps->stdHeaderVersion.extensionName,
> +           dec_ext[avctx->codec_id]->extensionName);
>  av_log(avctx, AV_LOG_VERBOSE, "    Codec header version: %i.%i.%i (driver), %i.%i.%i (compiled)\n",
>  CODEC_VER(caps->stdHeaderVersion.specVersion),
>  CODEC_VER(dec_ext[avctx->codec_id]->specVersion));
>

Pushed, along with the first commit in the patchset.
As for the second, Mesa still doesn't signal a correct version,a
and I'd rather have at least one fully working implementation at any time.
diff mbox series

Patch

diff --git a/libavcodec/vulkan_decode.c b/libavcodec/vulkan_decode.c
index 7607edf52e..0d561b7450 100644
--- a/libavcodec/vulkan_decode.c
+++ b/libavcodec/vulkan_decode.c
@@ -863,6 +863,9 @@  static int vulkan_decode_get_profile(AVCodecContext *avctx, AVBufferRef *frames_
            caps->maxDpbSlots);
     av_log(avctx, AV_LOG_VERBOSE, "    Maximum active references: %u\n",
            caps->maxActiveReferencePictures);
+    av_log(avctx, AV_LOG_VERBOSE, "    Codec header name: '%s' (driver), '%s' (compiled)\n",
+           caps->stdHeaderVersion.extensionName,
+           dec_ext[avctx->codec_id]->extensionName);
     av_log(avctx, AV_LOG_VERBOSE, "    Codec header version: %i.%i.%i (driver), %i.%i.%i (compiled)\n",
            CODEC_VER(caps->stdHeaderVersion.specVersion),
            CODEC_VER(dec_ext[avctx->codec_id]->specVersion));