diff mbox series

[FFmpeg-devel] doc/encoders/libxvid: fix references for me_quality option

Message ID 20230826105610.85148-1-stefasab@gmail.com
State New
Headers show
Series [FFmpeg-devel] doc/encoders/libxvid: fix references for me_quality option | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Stefano Sabatini Aug. 26, 2023, 10:56 a.m. UTC 
Drop reference to constants removed in 94eed68ace9f2416af8.

In particular, rename me_method to me_quality and add description for
supported values.

Address trac issue:
http://trac.ffmpeg.org/ticket/10003
---
 doc/encoders.texi | 21 +++++++++------------
 1 file changed, 9 insertions(+), 12 deletions(-)

Comments

Stefano Sabatini Sept. 5, 2023, 11:12 p.m. UTC | #1 
On date Saturday 2023-08-26 12:56:10 +0200, Stefano Sabatini wrote:
> Drop reference to constants removed in 94eed68ace9f2416af8.
> 
> In particular, rename me_method to me_quality and add description for
> supported values.
> 
> Address trac issue:
> http://trac.ffmpeg.org/ticket/10003
> ---
>  doc/encoders.texi | 21 +++++++++------------
>  1 file changed, 9 insertions(+), 12 deletions(-)
> 
> diff --git a/doc/encoders.texi b/doc/encoders.texi
> index 14c69fc7b3..25c40a6486 100644
> --- a/doc/encoders.texi
> +++ b/doc/encoders.texi
> @@ -2981,27 +2981,24 @@ Place global headers in extradata instead of every keyframe.
>  
>  @item trellis
>  
> -@item me_method
> -Set motion estimation method. Possible values in decreasing order of
> +@item me_quality
> +Set motion estimation quality level. Possible values in decreasing order of
>  speed and increasing order of quality:
>  
>  @table @samp
> -@item zero
> +@item 0
>  Use no motion estimation (default).
>  
> -@item phods
> -@item x1
> -@item log
> +@item 1, 2
>  Enable advanced diamond zonal search for 16x16 blocks and half-pixel
> -refinement for 16x16 blocks. @samp{x1} and @samp{log} are aliases for
> -@samp{phods}.
> +refinement for 16x16 blocks.
>  
> -@item epzs
> +@item 3, 4
>  Enable all of the things described above, plus advanced diamond zonal
> -search for 8x8 blocks, half-pixel refinement for 8x8 blocks, and motion
> -estimation on chroma planes.
> +search for 8x8 blocks and half-pixel refinement for 8x8 blocks, also
> +enable motion estimation on chrom planes for P and B-frames.
>  
> -@item full
> +@item 5, 6
>  Enable all of the things described above, plus extended 16x16 and 8x8
>  blocks search.
>  @end table

Will apply in a few days if I see no comments.
Gyan Doshi Sept. 6, 2023, 5:26 a.m. UTC | #2 
On 2023-08-26 04:26 pm, Stefano Sabatini wrote:
> Drop reference to constants removed in 94eed68ace9f2416af8.
>
> In particular, rename me_method to me_quality and add description for
> supported values.
>
> Address trac issue:
> http://trac.ffmpeg.org/ticket/10003
> ---
>   doc/encoders.texi | 21 +++++++++------------
>   1 file changed, 9 insertions(+), 12 deletions(-)
>
> diff --git a/doc/encoders.texi b/doc/encoders.texi
> index 14c69fc7b3..25c40a6486 100644
> --- a/doc/encoders.texi
> +++ b/doc/encoders.texi
> @@ -2981,27 +2981,24 @@ Place global headers in extradata instead of every keyframe.
>   
>   @item trellis
>   
> -@item me_method
> -Set motion estimation method. Possible values in decreasing order of
> +@item me_quality
> +Set motion estimation quality level. Possible values in decreasing order of
>   speed and increasing order of quality:
>   
>   @table @samp
> -@item zero
> +@item 0
>   Use no motion estimation (default).
>   
> -@item phods
> -@item x1
> -@item log
> +@item 1, 2
>   Enable advanced diamond zonal search for 16x16 blocks and half-pixel
> -refinement for 16x16 blocks. @samp{x1} and @samp{log} are aliases for
> -@samp{phods}.
> +refinement for 16x16 blocks.
>   
> -@item epzs
> +@item 3, 4
>   Enable all of the things described above, plus advanced diamond zonal
> -search for 8x8 blocks, half-pixel refinement for 8x8 blocks, and motion
> -estimation on chroma planes.
> +search for 8x8 blocks and half-pixel refinement for 8x8 blocks, also
> +enable motion estimation on chrom planes for P and B-frames.
s/chrom/chroma

>   
> -@item full
> +@item 5, 6
>   Enable all of the things described above, plus extended 16x16 and 8x8
>   blocks search.
>   @end table

Else, LGTM.

Regards,
Gyan
Stefano Sabatini Oct. 6, 2023, 7:54 a.m. UTC | #3 
On date Wednesday 2023-09-06 10:56:43 +0530, Gyan Doshi wrote:
> On 2023-08-26 04:26 pm, Stefano Sabatini wrote:
> > Drop reference to constants removed in 94eed68ace9f2416af8.
> > 
> > In particular, rename me_method to me_quality and add description for
> > supported values.
> > 
> > Address trac issue:
> > http://trac.ffmpeg.org/ticket/10003
> > ---
> >   doc/encoders.texi | 21 +++++++++------------
> >   1 file changed, 9 insertions(+), 12 deletions(-)
> > 
> > diff --git a/doc/encoders.texi b/doc/encoders.texi
> > index 14c69fc7b3..25c40a6486 100644
> > --- a/doc/encoders.texi
> > +++ b/doc/encoders.texi
> > @@ -2981,27 +2981,24 @@ Place global headers in extradata instead of every keyframe.
> >   @item trellis
> > -@item me_method
> > -Set motion estimation method. Possible values in decreasing order of
> > +@item me_quality
> > +Set motion estimation quality level. Possible values in decreasing order of
> >   speed and increasing order of quality:
> >   @table @samp
> > -@item zero
> > +@item 0
> >   Use no motion estimation (default).
> > -@item phods
> > -@item x1
> > -@item log
> > +@item 1, 2
> >   Enable advanced diamond zonal search for 16x16 blocks and half-pixel
> > -refinement for 16x16 blocks. @samp{x1} and @samp{log} are aliases for
> > -@samp{phods}.
> > +refinement for 16x16 blocks.
> > -@item epzs
> > +@item 3, 4
> >   Enable all of the things described above, plus advanced diamond zonal
> > -search for 8x8 blocks, half-pixel refinement for 8x8 blocks, and motion
> > -estimation on chroma planes.
> > +search for 8x8 blocks and half-pixel refinement for 8x8 blocks, also
> > +enable motion estimation on chrom planes for P and B-frames.
> s/chrom/chroma
> 
> > -@item full
> > +@item 5, 6
> >   Enable all of the things described above, plus extended 16x16 and 8x8
> >   blocks search.
> >   @end table
> 
> Else, LGTM.

Applied, thanks.
diff mbox series

Patch

diff --git a/doc/encoders.texi b/doc/encoders.texi
index 14c69fc7b3..25c40a6486 100644
--- a/doc/encoders.texi
+++ b/doc/encoders.texi
@@ -2981,27 +2981,24 @@  Place global headers in extradata instead of every keyframe.
 
 @item trellis
 
-@item me_method
-Set motion estimation method. Possible values in decreasing order of
+@item me_quality
+Set motion estimation quality level. Possible values in decreasing order of
 speed and increasing order of quality:
 
 @table @samp
-@item zero
+@item 0
 Use no motion estimation (default).
 
-@item phods
-@item x1
-@item log
+@item 1, 2
 Enable advanced diamond zonal search for 16x16 blocks and half-pixel
-refinement for 16x16 blocks. @samp{x1} and @samp{log} are aliases for
-@samp{phods}.
+refinement for 16x16 blocks.
 
-@item epzs
+@item 3, 4
 Enable all of the things described above, plus advanced diamond zonal
-search for 8x8 blocks, half-pixel refinement for 8x8 blocks, and motion
-estimation on chroma planes.
+search for 8x8 blocks and half-pixel refinement for 8x8 blocks, also
+enable motion estimation on chrom planes for P and B-frames.
 
-@item full
+@item 5, 6
 Enable all of the things described above, plus extended 16x16 and 8x8
 blocks search.
 @end table