diff mbox series

[FFmpeg-devel,11/11] fftools/ffplay: stop injecting stream side data in packets

Message ID 20230927131242.1950-12-jamrial@gmail.com
State New
Headers show
Series AVCodecContext and AVCodecParameters side data | expand

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

James Almer Sept. 27, 2023, 1:12 p.m. UTC 
This is no longer needed as the side data is available for decoders in the
AVCodecContext.

Signed-off-by: James Almer <jamrial@gmail.com>
---
 fftools/ffplay.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Anton Khirnov Oct. 3, 2023, 10:11 a.m. UTC | #1 
Quoting James Almer (2023-09-27 15:12:42)
> This is no longer needed as the side data is available for decoders in the
> AVCodecContext.
> 
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>  fftools/ffplay.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fftools/ffplay.c b/fftools/ffplay.c
> index e29b0ad0f9..87e04226c9 100644
> --- a/fftools/ffplay.c
> +++ b/fftools/ffplay.c
> @@ -2794,8 +2794,6 @@ static int read_thread(void *arg)
>      if (genpts)
>          ic->flags |= AVFMT_FLAG_GENPTS;
>  
> -    av_format_inject_global_side_data(ic);

Are you planning to remove this function entirely?
Anton Khirnov Oct. 3, 2023, 11:28 a.m. UTC | #2 
Quoting Anton Khirnov (2023-10-03 12:11:52)
> Quoting James Almer (2023-09-27 15:12:42)
> > This is no longer needed as the side data is available for decoders in the
> > AVCodecContext.
> > 
> > Signed-off-by: James Almer <jamrial@gmail.com>
> > ---
> >  fftools/ffplay.c | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/fftools/ffplay.c b/fftools/ffplay.c
> > index e29b0ad0f9..87e04226c9 100644
> > --- a/fftools/ffplay.c
> > +++ b/fftools/ffplay.c
> > @@ -2794,8 +2794,6 @@ static int read_thread(void *arg)
> >      if (genpts)
> >          ic->flags |= AVFMT_FLAG_GENPTS;
> >  
> > -    av_format_inject_global_side_data(ic);
> 
> Are you planning to remove this function entirely?

Oh, I didn't notice it's being deprecated in an earlier patch.
Nevermind then.
diff mbox series

Patch

diff --git a/fftools/ffplay.c b/fftools/ffplay.c
index e29b0ad0f9..87e04226c9 100644
--- a/fftools/ffplay.c
+++ b/fftools/ffplay.c
@@ -2794,8 +2794,6 @@  static int read_thread(void *arg)
     if (genpts)
         ic->flags |= AVFMT_FLAG_GENPTS;
 
-    av_format_inject_global_side_data(ic);
-
     if (find_stream_info) {
         AVDictionary **opts;
         int orig_nb_streams = ic->nb_streams;